Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify KVIKIO_CUFILE_FOUND #243

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Unify KVIKIO_CUFILE_FOUND #243

merged 2 commits into from
Jun 20, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jun 14, 2023

Fixing a mismatch where CMake cannot find cuFile but later when compiling, GCC finds cufile.h using __has_include().

To fix this, CMake now defines KVIKIO_CUFILE_FOUND and we stop using __has_include().

@madsbk madsbk added bug Something isn't working non-breaking Introduces a non-breaking change labels Jun 14, 2023
@madsbk madsbk marked this pull request as ready for review June 14, 2023 08:01
@madsbk madsbk requested a review from bdice June 19, 2023 07:07
wence-
wence- approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks right.

@madsbk
Copy link
Member Author

madsbk commented Jun 20, 2023

Thanks @wence-

@madsbk
Copy link
Member Author

madsbk commented Jun 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit 65f84e6 into rapidsai:branch-23.08 Jun 20, 2023
@madsbk madsbk deleted the fix_cufile_include branch June 20, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@bdice bdice Awaiting requested review from bdice

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsbk @wence-