Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to get compatibility mode status in a FileHandle object #197

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Add API to get compatibility mode status in a FileHandle object #197

merged 3 commits into from
Apr 21, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Apr 17, 2023 •
edited
Loading

Adding is_compat_mode_on() to FileHandle to make the run-time behavior more transparent for the users.

@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 18, 2023
@vuule vuule marked this pull request as ready for review April 18, 2023 20:05
@vuule vuule requested a review from madsbk April 20, 2023 17:54
madsbk
madsbk approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @vuule

@madsbk
Copy link
Member

madsbk commented Apr 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit cd30dd7 into rapidsai:branch-23.06 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuule @madsbk