Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove underscore in build string. #188

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Remove underscore in build string. #188

merged 1 commit into from
Mar 29, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 28, 2023

This PR removes the underscore after "cuda" to align with other RAPIDS packages.

@bdice bdice marked this pull request as ready for review March 28, 2023 17:57
msadang
msadang approved these changes Mar 28, 2023
View reviewed changes
Copy link

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String change looks good.

@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 28, 2023
@bdice
Copy link
Contributor Author

bdice commented Mar 28, 2023

Needs a /merge from someone with write access. cc: @madsbk

madsbk
madsbk approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice

@madsbk
Copy link
Member

madsbk commented Mar 29, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8868882 into rapidsai:branch-23.06 Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msadang msadang msadang approved these changes

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @madsbk @msadang @ajschmidt8