Support of stream ordered device memory allocations (async mallocs) #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
bug
madsbk
force-pushed
the
use_current_context
branch
from
11f78c1 to
a0c75eb
Compare
|
I'm still seeing the same error with this PR as reported in rapidsai/cudf#12865 . Do you think I need to rebuild cuDF as well ? |
Yes, sorry should have made that clear. You have to build cudf with this PR, which can be done by setting the kvikio source cudf's diff --git a/build.sh b/build.sh
index bee66d819b..b6bcf5ce75 100755
--- a/build.sh
+++ b/build.sh
@@ -288,6 +288,7 @@ if buildAll || hasArg libcudf; then
-DDISABLE_DEPRECATION_WARNINGS=${BUILD_DISABLE_DEPRECATION_WARNINGS} \
-DCUDF_USE_PER_THREAD_DEFAULT_STREAM=${BUILD_PER_THREAD_DEFAULT_STREAM} \
-DCMAKE_BUILD_TYPE=${BUILD_TYPE} \
+ -DCPM_KvikIO_SOURCE=/home/mkristensen/repos/kvikio \
${EXTRA_CMAKE_ARGS}
cd ${LIB_BUILD_DIR} |
quasiben
approved these changes
Mar 10, 2023
|
Thanks so much @madsbk ! |
|
/merge |
This was referenced Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we call
cuPointerGetAttribute(..., CU_POINTER_ATTRIBUTE_CONTEXT)to set the CUDA context for each IO task. However, this doesn't work for stream ordered device memory allocations so we now get the current cuda context instead.Closes rapidsai/cudf#12865