Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GCC 11 #179

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Update to GCC 11 #179

merged 3 commits into from
Mar 8, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 28, 2023

This PR updates builds to use GCC 11.

@bdice bdice mentioned this pull request Feb 28, 2023
Merged
@madsbk madsbk added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 1, 2023
@bdice bdice marked this pull request as ready for review March 2, 2023 02:37
@bdice
Copy link
Contributor Author

bdice commented Mar 2, 2023

This is ready for review, but please do not merge until all RAPIDS repos are ready to migrate. (I do not have privileges to add the DO NOT MERGE label to prohibit merging.)

madsbk
madsbk requested changes Mar 2, 2023
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bdice, looks good.
We don't have a DO NOT MERGE label so I am setting Request changes.
Please let me know when this should be merged

@raydouglass raydouglass requested a review from madsbk March 6, 2023 20:29
@raydouglass
Copy link
Member

/merge

@jakirkham
Copy link
Member

@madsbk, would you be able to give this another look?

madsbk
madsbk approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rapids-bot rapids-bot bot merged commit 9eb0822 into rapidsai:branch-23.04 Mar 8, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bdice @raydouglass @jakirkham @madsbk @jjacobelli