nvcomp xfail compression ratios #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
improvement
quasiben
approved these changes
Feb 7, 2023
|
/merge |
vuule
pushed a commit
to vuule/kvikio
that referenced
this pull request
Nov 8, 2023
* Revert "Fix checking for calling module" This reverts commit c071769. * Some wording changes * More doc additions * More docs improvements * Remove title * Formatting * Docs update * Phrasing * Docs update * Change profiler message * Don't reference cudf-private * Remove benchmarks-full.md * Reviews * Review comments * Review suggestions * Benchmark notes update --------- Co-authored-by: Ashwin Srinath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mismatch in compression ratios now results in a
XFAIL.In #156 we allowed a small compression ratio mismatch however this isn't enough when testing on ARM.
cc. @thomcom @AjayThorve