Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CUDA 12.5 to conda nightlys in the selector #522

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add CUDA 12.5 to conda nightlys in the selector #522

merged 2 commits into from
Jul 22, 2024

Conversation

jarmak-nv
Copy link
Contributor

Small PR that adds CUDA 12.5 to the conda nightlys.

When 24.08 releases a followup PR will be made that:

  1. Sets 12.5 as the default
  2. Removes 12.2 as an option (still supported but not necessary for the selector)

@jarmak-nv jarmak-nv self-assigned this Jul 17, 2024
@jarmak-nv jarmak-nv requested a review from a team as a code owner July 17, 2024 19:55
@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d13a9b4
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/669823cf81e4c700082e7f7f
😎 Deploy Preview https://deploy-preview-522--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jakirkham
Copy link
Member

xref: rapidsai/build-planning#73

@jakirkham jakirkham mentioned this pull request Jul 17, 2024
Closed
13 tasks
bdice
bdice approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. We may be able to remove CUDA 11.2 from the selector, so that we don’t list 5 versions. conda-forge has moved entirely to building with 11.8, and we no longer test 11.2 in our CI workflows.

@jarmak-nv
Copy link
Contributor Author

This looks fine. We may be able to remove CUDA 11.2 from the selector, so that we don’t list 5 versions. conda-forge has moved entirely to building with 11.8, and we no longer test 11.2 in our CI workflows.

With this info, I'm in favor of removing 11.2 here and potentially doing an RSN to drop support altogether.

Also curious if there's a benefit to having 12.0 here. My preference is that the selector helps get people on our recommended versions, so 12.latest if on 12 and 11.8 if on 11. But, not sure if that would cause problems for tensorflow or pytorch.

@bdice
Copy link
Contributor

bdice commented Jul 22, 2024

My preference is that the selector helps get people on our recommended versions

I like that. I would envision this:

  • conda shows “CUDA 11” or “CUDA 12”, which then fill out cuda-version=11.* or cuda-version=12.*
  • pip shows “CUDA 11” or “CUDA 12”, which resolves to the proper major suffix
  • Docker shows each CUDA version for which we produce containers

How would that sound?

@bdice
Copy link
Contributor

bdice commented Jul 22, 2024

cc: @sisodia1701 @raydouglass @jameslamb @KyleFromNVIDIA if you have thoughts on the discussions above

@jarmak-nv
Copy link
Contributor Author

My preference is that the selector helps get people on our recommended versions

I like that. I would envision this:

* conda shows “CUDA 11” or “CUDA 12”, which then fill out `cuda-version=11.*` or `cuda-version=12.*`

* pip shows “CUDA 11” or “CUDA 12”, which resolves to the proper major suffix

* Docker shows each CUDA version for which we produce containers

How would that sound?

I love this idea!

In situations like this PR where there's a new nightly-only version of CUDA we can have a temp 3rd button that says something like: "RAPIDS 12.5 Pre-Release". I think that's not right, but something to show that it's upcoming support.

jakirkham
jakirkham reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben! 🙏

Thinking about the discussion above, what if we converted this to CUDA version ranges?

This might also address some of the confusion raised by others in the past about what CUDA versions we support. Not to mention whether a CUDA version can be found that works with RAPIDS and other 3rd party libraries (like PyTorch)

Showed a small sample of this below. Though there may be other adjustments needed if we pursue this approach

_includes/selector.html
@@ -371,7 +371,7 @@

// all possible values
python_vers: ["3.9", "3.10", "3.11"],
cuda_vers: ["11.2", "11.8", "12.0", "12.2"],
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"],
cuda_vers: ["11.4-11.8", "12.0-12.2", "12.0-12.5"],

Copy link
Contributor

@bdice bdice Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea but I don't think we need to have both 12.0-12.2 and 12.0-12.5. We should have only one CUDA 12 range.

Suggested change
cuda_vers: ["11.2", "11.8", "12.0", "12.2", "12.5"],
cuda_vers: ["11.4-11.8", "12.0-12.5"],

Copy link
Member

@jakirkham jakirkham Jul 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the only reason there are both now is one range is for nightlies and one is for stable (since the two are handled differently atm). If we did this after the release, we could just have one

@bdice
Copy link
Contributor

bdice commented Jul 22, 2024

@jakirkham @jarmak-nv I propose to merge this as-is, and file a follow-up PR with the changes we are proposing for CUDA version ranges instead of individual minor versions.

@jakirkham
Copy link
Member

SGTM

@bdice bdice merged commit 41d220a into rapidsai:main Jul 22, 2024
5 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@bdice bdice mentioned this pull request Jul 22, 2024
Merged
@jarmak-nv jarmak-nv deleted the cuda-12-5-nightly-selector branch July 22, 2024 23:48
@raydouglass raydouglass mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees

@jarmak-nv jarmak-nv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jarmak-nv @jakirkham @bdice @ajschmidt8