Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.9 support #1443

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Drop Python 3.9 support #1443

merged 1 commit into from
Aug 23, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#88

Finishes the work of dropping Python 3.9 support.

This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235.
This PR updates configuration and docs to reflect that.

Notes for Reviewers

How I tested this

Checked that there were no remaining uses like this:

git grep -E '3\.9'
git grep '39'
git grep 'py39'

And similar for variations on Python 3.8 (to catch things that were missed the last time this was done).

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 22, 2024
@github-actions github-actions bot added conda Related to conda and conda configuration Python Related to Python code labels Aug 22, 2024
@jameslamb jameslamb mentioned this pull request Aug 22, 2024
Closed
11 tasks
@jameslamb jameslamb changed the title WIP: Drop Python 3.9 support Drop Python 3.9 support Aug 22, 2024
@jameslamb jameslamb marked this pull request as ready for review August 22, 2024 15:56
@jameslamb jameslamb requested a review from a team as a code owner August 22, 2024 15:56
@jameslamb jameslamb requested a review from msarahan August 22, 2024 15:56
jakirkham
jakirkham reviewed Aug 23, 2024
View reviewed changes
pyproject.toml
Comment on lines +1 to +2
# Copyright (c) 2019-2024, NVIDIA CORPORATION.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🙏

jakirkham
jakirkham approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks James! 🙏

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e323178 into rapidsai:branch-24.10 Aug 23, 2024
58 checks passed
@jameslamb jameslamb deleted the drop-python-3.9 branch August 23, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

@harrism harrism harrism approved these changes

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@msarahan msarahan

Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jameslamb @jakirkham @harrism @msarahan