fix: improve TON signer and MyTonWallet provider
#914
Conversation
Ikari-Shinji-re
changed the title
TON signer and MyTonWallet providerTON signer and MyTonWallet provider
Ikari-Shinji-re
requested review from
mikasackermn,
samobasquiat and
yeager-eren
as code owners
Ikari-Shinji-re
force-pushed
the
fix/improve-ton-signer-and-mytonwallet-provider
branch
from
901efcb to
17ad1fa
Compare
| export const TON_CONNECT_MANIFEST_URL = | ||
| 'https://raw.githubusercontent.com/rango-exchange/rango-types/main/assets/manifests/tonconnect-manifest.json'; |
There was a problem hiding this comment.
Please move default manifest to assets repo instead.
Ikari-Shinji-re
force-pushed
the
fix/improve-ton-signer-and-mytonwallet-provider
branch
from
17ad1fa to
8b3f804
Compare
yeager-eren
left a comment
yeager-eren
left a comment
There was a problem hiding this comment.
Thanks for your effort on this. I've put some comments to address.
Please also make sure you will let QA know to check playground and exporting config as well.
widget/app/package.json
Outdated
| "browserslist": "> 0.5%, last 2 versions, not dead", | ||
| "scripts": { | ||
| "dev": "parcel -p 3002 --cache-dir=.parcel-cache --no-cache", | ||
| "dev": "parcel -p 3000 --cache-dir=.parcel-cache --no-cache", |
There was a problem hiding this comment.
Why this needed to be changed?
There was a problem hiding this comment.
Any changes to the API base URL, port, or API key are necessary for testing the staging environment. However, these changes must be reverted before merging this pull request.
| } | ||
|
|
||
| export function parseAddress(rawAddress: string): string { | ||
| return Address.parse(rawAddress).toString({ bounceable: false }); |
There was a problem hiding this comment.
I guess it is a backend requirement but can explain why it should be non-bouncable? for the record.
There was a problem hiding this comment.
No, that's not exactly the reason. I checked with the backend team, and they confirmed it doesn't make a difference for them. However, based on the documentation, I updated the address to a non-bounceable format. Additionally, if you connect using the MyTonWallet provider, you'll notice that the address shown in the provider extension now matches the one displayed in our app.
https://docs.ton.org/v3/documentation/smart-contracts/addresses#bounceable-vs-non-bounceable-addresses
This comment was marked as resolved.
This comment was marked as resolved.
yeager-eren
force-pushed
the
fix/improve-ton-signer-and-mytonwallet-provider
branch
2 times, most recently
from
59a893c to
25f4b7a
Compare
Ikari-Shinji-re
force-pushed
the
fix/improve-ton-signer-and-mytonwallet-provider
branch
from
3730062 to
575d599
Compare
yeager-eren
deleted the
fix/improve-ton-signer-and-mytonwallet-provider
branch
Summary
TONtokens are not being displayed correctly in the token listnon-bounceableaddress for theMytonWalletproviderBOCafter signing theTONtransactionHow did you test this change?
TONtokens in the token list. Ensure that if a token has an address or name, it is displayed correctly. You can verify this by checking the meta response from the network tab and comparing it with the UI.MytonWalletprovider. The address displayed in the confirmation wallet modal must match the address selected and shown in theMytonWalletUI.TONblockchain as the source. Sign the transaction and check the network tab to ensure that the hash of the message is sent to the server with thecheckStatusrequest.Note
There are some considerations for using the provider API instead of the
tonconnect/sdk. Since the main pull request was made over a year ago, I might not recall everything, but here are a few points:tonconnect/sdkuses callbacks to handle wallet connection events, which added extra effort for implementation.Checklist: