chore: improve and document code splitting #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyukTheCoder
requested review from
Ikari-Shinji-re,
RanGojo,
mikasackermn,
samobasquiat and
yeager-eren
as code owners
RyukTheCoder
commented
Oct 15, 2024
| import { getNetworkInstance, Networks } from '@rango-dev/wallets-shared'; | ||
| import { DefaultSignerFactory, TransactionType as TxType } from 'rango-types'; | ||
|
|
||
| import { CustomSolanaSigner } from './solana-signer.js'; |
Contributor
Author
There was a problem hiding this comment.
Wee didn't lazy import DefaultSolanaSigner at all. Lazy importing these CustomSolanaSigner s will result in small chunks
| @@ -1,12 +1,12 @@ | |||
| import type { SignerFactory } from 'rango-types'; | |||
|
|
|||
| import { DefaultStarknetSigner } from '@rango-dev/signer-starknet'; | |||
Contributor
Author
There was a problem hiding this comment.
DefaultStarknetSigner has no dependency and result in small chunks so removed dynamic import.
yeager-eren
force-pushed
the
chore/rf-1807-improve-and-document-code-splitting
branch
from
2fabc5d to
efd830e
Compare
yeager-eren
approved these changes
Nov 25, 2024
Collaborator
yeager-eren
left a comment
yeager-eren
left a comment
There was a problem hiding this comment.
This PR didn't completely resolved the small chunks issues, less than %10 affected. I will merge this PR, and will address the rest of issues in a separate PR.
yeager-eren
deleted the
chore/rf-1807-improve-and-document-code-splitting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a document for
code-splittingand also detected some dynamic imports which result in small chunks and reverted such dynamic imports. I've added list of files resulted in build process inwidget-examples\viteBuild result before code splitting:
Build result before changes:
Build result after changes:
How did you test this change?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: