test: add tests for wallets/react #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeager-eren
changed the title
yeager-eren
force-pushed
the
chore/rf-1731-wallets-react-tests
branch
2 times, most recently
from
ca2a758 to
98dec66
Compare
2 tasks
yeager-eren
changed the base branch from
next
to
feat/support-for-both-legacy-and-hub
yeager-eren
force-pushed
the
chore/rf-1731-wallets-react-tests
branch
from
98dec66 to
88173e0
Compare
yeager-eren
changed the title
RyukTheCoder
requested changes
Oct 15, 2024
| legacyProvider, | ||
| } from '../src/test-utils/fixtures.js'; | ||
|
|
||
| describe('check legacy is working correctly', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe('check legacy is working correctly', () => { | |
| describe('legacy is working correctly', () => { |
I think "check" is redundant
Collaborator
Author
There was a problem hiding this comment.
It's kinda convention to start with a verb
| }); | ||
| }); | ||
|
|
||
| describe('check legacy switching network', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| describe('check legacy switching network', () => { | |
| describe('legacy switch network works properly', () => { |
I think it would be helpful if you follow a specific convention
Collaborator
Author
There was a problem hiding this comment.
| ); | ||
| }); | ||
|
|
||
| test('will be ignored and use first namespace when passing multiple namespaces', async () => { |
Contributor
There was a problem hiding this comment.
I have added a comment related to this test on adapter PR
yeager-eren
force-pushed
the
feat/support-for-both-legacy-and-hub
branch
from
ab16aea to
9355468
Compare
yeager-eren
force-pushed
the
feat/support-for-both-legacy-and-hub
branch
from
9355468 to
1f9f637
Compare
yeager-eren
force-pushed
the
feat/support-for-both-legacy-and-hub
branch
2 times, most recently
from
f0db76c to
455bafc
Compare
yeager-eren
force-pushed
the
feat/support-for-both-legacy-and-hub
branch
2 times, most recently
from
27f3bbe to
63f00c5
Compare
yeager-eren
force-pushed
the
chore/rf-1731-wallets-react-tests
branch
2 times, most recently
from
066a718 to
9f062f8
Compare
yeager-eren
force-pushed
the
chore/rf-1731-wallets-react-tests
branch
from
9f062f8 to
cdb1875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add integration tests for
walelt-react.This PR includes some integration tests for legacy provider and also some todo tests for doing for future.
Fixes RF-1731
How did you test this change?
Run
yarn testRelated PRs
Checklist:
Notes
First I need to change
connectinterface for legacy.