feat(wallets): add evm to tron link #350
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
- [email protected] Affected packages: [email protected]
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] Affected packages: [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
nikaaru
commented
Sep 2, 2023
.eslintrc.json
Outdated
| "parserOptions": { | ||
| "ecmaVersion": "latest", | ||
| "sourceType": "module", | ||
| // "project": ["tsconfig.base.json"] |
Member
Author
There was a problem hiding this comment.
@yeager-eren
please check eslint parser issue
yeager-eren
reviewed
Sep 13, 2023
| const { tronLink, TronLinkEVM } = window; | ||
|
|
||
| if (!tronLink) { | ||
| return tronLink; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return tronLink; | |
| return null; |
Make it more explicit.
|
|
||
| export const config = { | ||
| type: WALLET, | ||
| defaultNetwork: Networks.TRON, |
Collaborator
There was a problem hiding this comment.
Default network is tron, When you are on Ethereum network on TronLink, it goes through an error. How we can fix it?
| if (!r) { | ||
| const results: ProviderConnectResult[] = []; | ||
|
|
||
| if (ethInstance) { |
Collaborator
There was a problem hiding this comment.
It tries to connect to Ethereum and Tron (instance) at the same time but the wallet seems doesn't support that and one network should be connected at the same time.
|
|
||
| ethInstance?.on('accountsChanged', (addresses: string[]) => { | ||
| const eth_chainId = meta | ||
| .filter(isEvmBlockchain) |
Collaborator
There was a problem hiding this comment.
Is this line need as long as you have a find?
| ethInstance?.on('accountsChanged', (addresses: string[]) => { | ||
| const eth_chainId = meta | ||
| .filter(isEvmBlockchain) | ||
| .find((blockchain) => blockchain.name === Networks.ETHEREUM)?.chainId; |
Collaborator
There was a problem hiding this comment.
Do we need to support for BSC as well?
| .filter(isEvmBlockchain) | ||
| .find((blockchain) => blockchain.name === Networks.ETHEREUM)?.chainId; | ||
| if (state.connected) { | ||
| if (state.network != Networks.ETHEREUM && eth_chainId) { |
Collaborator
There was a problem hiding this comment.
I'm not sure why we need this condition here.
| export const getWalletInfo: (allBlockChains: BlockchainMeta[]) => WalletInfo = ( | ||
| allBlockChains | ||
| ) => { | ||
| const evms = evmBlockchains(allBlockChains); |
Collaborator
There was a problem hiding this comment.
It returns the whole list evm compatible networks, but we only need BSC and ETH here as the wallet only has support for this.
yeager-eren
requested review from
Ikari-Shinji-re,
mikasackermn and
samobasquiat
as code owners
yeager-eren
force-pushed
the
next
branch
2 times, most recently
from
9431967 to
6507542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.