Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Interruptible #417

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Reimplement Interruptible #417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e5561b
Minor housekeeping
hms Nov 17, 2024
6cc550e
Silence test output for expected exceptions
hms Nov 17, 2024
a152f26
Reimplement Interruptible using Thread#queue
hms Nov 15, 2024
17c4cd5
Addresses PR feedback
hms Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Minor housekeeping 
* Adds to RVM .ruby-gemset to .gitignore for RVM and gemset holdouts.
* Updates Gemfile.lock to include arm64-darwin-24 (weird that it's
  missing)
* Adds 4 development dependencies to quiet deprecation warnings
* Updates rubocop to allow Ruby 3.3 syntax, matching .ruby-version
  • Loading branch information
@hms
hms committed Dec 2, 2024
commit 0e5561b4c710d81a7bcdf826a4c47120b882af0d
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,8 @@
# Folder for Visual Studio Code
/.vscode/

# Files for RVM holdouts
.ruby-gemset

# misc
.DS_Store
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
inherit_gem: { rubocop-rails-omakase: rubocop.yml }

AllCops:
TargetRubyVersion: 3.0
TargetRubyVersion: 3.3
Exclude:
- "test/dummy/db/schema.rb"
- "test/dummy/db/queue_schema.rb"
7 changes: 7 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ GEM
erubi (1.13.0)
et-orbi (1.2.11)
tzinfo
fiddle (1.1.2)
fugit (1.11.1)
et-orbi (~> 1, >= 1.2.11)
raabro (~> 1.4)
Expand All @@ -74,6 +75,7 @@ GEM
reline (>= 0.4.2)
json (2.8.2)
language_server-protocol (3.17.0.3)
logger (1.6.0)
loofah (2.23.1)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -90,6 +92,7 @@ GEM
racc (~> 1.4)
nokogiri (1.16.7-x86_64-linux)
racc (~> 1.4)
ostruct (0.6.0)
parallel (1.26.3)
parser (3.3.6.0)
ast (~> 2.4.1)
Expand Down Expand Up @@ -175,14 +178,18 @@ GEM
PLATFORMS
arm64-darwin-22
arm64-darwin-23
arm64-darwin-24
x86_64-darwin-21
x86_64-darwin-23
x86_64-linux

DEPENDENCIES
debug
fiddle
logger
mocha
mysql2
ostruct
pg
puma
rubocop-rails-omakase
Expand Down
3 changes: 3 additions & 0 deletions solid_queue.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "pg"
spec.add_development_dependency "sqlite3"
spec.add_development_dependency "rubocop-rails-omakase"
spec.add_development_dependency "ostruct"
spec.add_development_dependency "logger"
spec.add_development_dependency "fiddle"
hms marked this conversation as resolved.
Show resolved Hide resolved
end