Remove storage from gitignore if skip_active_storage and database is not sqlite3 #53417
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinibispo
force-pushed
the
fix/skip_storage-changes-gitignore
branch
from
e08b8ea to
2331e17
Compare
zzak
reviewed
Nov 1, 2024
zzak
reviewed
Nov 1, 2024
vinibispo
force-pushed
the
fix/skip_storage-changes-gitignore
branch
from
bc2cbca to
c037f5e
Compare
zzak
reviewed
Nov 3, 2024
|
Also, I forgot about this but can we also update |
vinibispo
force-pushed
the
fix/skip_storage-changes-gitignore
branch
from
1a4900a to
c76ed2d
Compare
zzak
approved these changes
Nov 3, 2024
…ge and database is not sqlite3 Fix rails#53413 Co-authored-by: zzak <[email protected]>
byroot
force-pushed
the
fix/skip_storage-changes-gitignore
branch
from
c76ed2d to
1849785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This pull request removes storage entries when active_storage is skipped and database is not sqlite3 and fixes #53413Detail
This Pull Request changes railties/lib/rails/generators/rails/app/templates/gitignore.tt
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]