Handle Rack 3.2 unprocessable_{entity,content}
#53383
Open
+29
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Using
unprocessable_entity
will emit a warning on Rack 3.2This to me seems like the least invasive change and is also how headers are currently handled.
There's some code in jbuilder that will need a similar change. https://github.com/search?q=org%3Arails+unprocessable_entity+-repo%3Arails%2Frails&type=code. I will take a look if this is accepted.
Question: Should
ActionDispatch::Constants
be nodoc? I think it should be but can that just be done now after it's been availale for a year?cc @ioquatix
Additional information
There have been various PRs in the past for this:
unprocessable_content
instead ofunprocessable_entity
#52192unprocessable_entity
->unprocessable_content
. #52097Maybe this will be the one.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]