Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Rack 3.2 unprocessable_{entity,content} #53383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Earlopain
Copy link
Contributor

Motivation / Background

Using unprocessable_entity will emit a warning on Rack 3.2

This to me seems like the least invasive change and is also how headers are currently handled.

There's some code in jbuilder that will need a similar change. https://github.com/search?q=org%3Arails+unprocessable_entity+-repo%3Arails%2Frails&type=code. I will take a look if this is accepted.

Question: Should ActionDispatch::Constants be nodoc? I think it should be but can that just be done now after it's been availale for a year?

cc @ioquatix

Additional information

There have been various PRs in the past for this:

Maybe this will be the one.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Using `unprocessable_entity` will emit a warning on Rack 3.2.
There have been various PRs in the past for this:
* rails#52252
* rails#52192
* rails#52087
* rails#52097

This to me seems like the least invasive change and is also how headers are currently handled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant