Set Current.session if signed-in in unauthenticated access #53220
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t27duck
changed the title
|
We were discussing this in Discord. For unauthenticated page views, the resume session will generate a query for User where def find_session_by_cookie
if (id = cookies.signed[:session_id])
Session.find_by(id: id)
end
end |
Currently, if you call `allow_unauthenticated_access` in a controller, `Current.session` won't be set. This can result in rendered views making the user appear to be signed out if they are already signed in. This updates `allow_unauthenticated_access` to set a `before_action` of `resume_session` to allow the user to still be signed in for requests that do not require authentication.
t27duck
force-pushed
the
resume_user_session_if_not_needed
branch
from
4f04b43 to
97cf64c
Compare
4 tasks
4 tasks
|
Seems like this only happens if you call Instead of: <% if Current.session %>
show me this
<% end %>Try: <% if authenticated? %>
show me this
<% end %>If you call (see #53557) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This is related to the authentication generator.
Currently, if you call
allow_unauthenticated_accessin a controller,Current.sessionwon't be set. This can result in rendered views making the user appear to be signed out if they are already signed in.Detail
This updates
allow_unauthenticated_accessto set abefore_actionofresume_sessionto allow the user to still be signed in for requests that do not require authentication.Additional information
Also included in this PR are two quick fixup commits:
Sessionmodel needlessly if the cookie isn't set.SessionsController#destroyshould redirect withsee_otherto match existing scaffolding controller destroy actions.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]