Fix uniqueness validation to correctly work with expression indexes #49483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
added a commit
that referenced
this pull request
Oct 4, 2023
…-indexes Fix uniqueness validation to correctly work with expression indexes
|
Thanks for the quick fix. I backported to 7-1-stable in bfc686f |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Oct 4, 2023
This test can be run against these bundled adapters if they `supports_expression_index?` returns `true` SQL statement to create unique index for generated column. - `sqlite3` adapter CREATE UNIQUE INDEX "topics_index" ON "topics" ((LOWER(title))) - `mysql2` and `trilogy` adapter CREATE UNIQUE INDEX `topics_index` ON `topics` ((LOWER(title))) - `postgresql` adapter CREATE UNIQUE INDEX "topics_index" ON "topics" ((LOWER(title))) Follow up rails#49483
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49481.
For expression indexes,
IndexDefinition#columnsis returned as a string and thats why we get an error.