Add support for defining default values as option for ActiveSupport::Configurable accessors #42030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotoral
changed the title
|
Hi @diegotoral thanks for the PR. |
|
Hi @p8! The idea is to make simpler to specify default values for config accessors. The current implementation requires the usage of a block for specifying those values which results in a many lines of code. class User
include ActiveSupport::Configurable
config_accessor :a, default: 1
config_accessor :b, default: 2
config_accessor :c, default: 3
# vs
config_accessor :a do
1
end
config_accessor :b do
2
end
config_accessor :c do
3
end
end |
There was a problem hiding this comment.
I think this makes sense for parity with class_attribute, which also has the instance_reader, instance_writer, and instance_accessor options.
diegotoral
force-pushed
the
configurable-default-option
branch
from
835252f to
b9c3182
Compare
|
@p8 @jonathanhefner updated the branch to apply the requested changes. 😄 |
Sometimes it can be very strange or long have to define default values for config accessors as blocks, specially when config is a simple value like 1, true, :symbol. This commit adds the ability to specify those values by just passing a ` default` option when defining the accessor. It also makes config accessor's interface similar to other Rails methods like `class_attribute`, which also has the instance_reader, instance_writer and instance_accessor options.
diegotoral
force-pushed
the
configurable-default-option
branch
from
b9c3182 to
99525cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes it can be very strange or long have to define default values for config accessors as blocks, specially for simple values. This commit adds the ability to specify those values by just passing a
defaultoption when defining the accessor.