Add locale selector to email preview #19923
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Is this going to generic ApplicationController? It's an unrelated change to emails, although perhaps useful to discuss in it's own right.
Author
|
@egilburg Rails::MailersController inherited from Rails::ApplicationController and use locale. I hope Rails::WelcomeController and Rails::InfoController can also be translated. |
Member
This will not happen. I can see reasons to accept different locales in mail previews since it change the result of the email body but not in Welcome and Info controllers. Let move this behavior to |
[ci skip] Don’t encourage `sudo gem install`
Conflicts: railties/lib/rails/templates/rails/mailers/email.html.erb
Member
|
Please squash the commits. Thanks! |
Member
|
Closing in favor of #31596. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafaelfranca Fix of #19922