Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken db:system:change #53219

Open
deepakmahakale opened this issue Oct 7, 2024 · 0 comments · May be fixed by #53217
Open

Broken db:system:change #53219

deepakmahakale opened this issue Oct 7, 2024 · 0 comments · May be fixed by #53217
Labels
attached PR railties

Comments

@deepakmahakale
Copy link
Contributor

Steps to reproduce

  1. Create a new rails app with rails 8.0.0.beta1
  2. Run rails db:system:change --to=mysql
  3. Notice the packages in Dockerfile has not changed
# Install rails 8.0.0.beta1
gem install rails --pre --no-document

# Create a new rails app
rails _8.0.0.beta1_ new dbtest

# Change the db to mysql
rails db:system:change --to=mysql

Expected behavior

# Install base packages
RUN apt-get update -qq && \
-   apt-get install --no-install-recommends -y curl libjemalloc2 libvips sqlite3 && \
+   apt-get install --no-install-recommends -y curl default-mysql-client libjemalloc2 libvips && \
    rm -rf /var/lib/apt/lists /var/cache/apt/archives

Actual behavior

# Install base packages
RUN apt-get update -qq && \
    apt-get install --no-install-recommends -y curl libjemalloc2 libvips sqlite3 && \
    rm -rf /var/lib/apt/lists /var/cache/apt/archives

System configuration

Rails version:
8.0.0.beta1

Ruby version:
ruby-3.2.2
@deepakmahakale deepakmahakale linked a pull request Oct 7, 2024 that will close this issue
Open
4 tasks
deepakmahakale added a commit to deepakmahakale/rails that referenced this issue Oct 7, 2024
@deepakmahakale
Fixes rails#53219 db:system:change generator issue
5f9a34a
deepakmahakale added a commit to deepakmahakale/rails that referenced this issue Oct 7, 2024
@deepakmahakale
Fixes rails#53219 db:system:change generator issue
e237d87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
attached PR railties
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix db system change generator deepakmahakale/rails
2 participants
@skipkayhil @deepakmahakale