-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails is not Django #1
Comments
That is a big issue. |
This is a problem. |
I’m glad it isn’t. |
I`m sure someone is working on a fix. |
Please don’t fix. |
-1 please don’t fix. don’t you python people have anything better to do? like scoop up pony power poop? |
Djan What ? How do you even pronounce it ?? |
Here is the fix: http://github.com/botanicus/rango/tree/master |
lulz |
…assignment assigns to existing record if the association is not yet loaded Issue rails#2: Nested Attributes assignment does not affect the record in the association target when callback triggers loading of the association Complete rewrite of tests
Fix an issue with where clause with a dot character.
Backport Patches for CVE-2013-0333
Clean up JobWrappers::ResqueWrapper.perform
All the methods that invoke `text_field_tag` (such as `hidden_field_tag`) and all the methods that invoke `number_field_tag` (that is `range_field_tag`) do not need to call `stringify_keys` on their `options` parameter since the `text_field_tag` method [is already doing it internally](https://github.com/claudiob/rails/blob/4159134524f4c78d008eef9d9a17f73a3172dcc8/actionview/lib/action_view/helpers/form_tag_helper.rb#L182): ```ruby def text_field_tag(name, value = nil, options = {}) tag :input, { "type" => "text", "name" => name, "id" => sanitize_to_id(name), "value" => value }.update(options.stringify_keys) end ``` and `number_field_tag` is [already doing it internally](https://github.com/claudiob/rails/blob/e3207bdbba55f3806441f22b175557579bc0b051/actionview/lib/action_view/helpers/form_tag_helper.rb#L780) as well: ```ruby def number_field_tag(name, value = nil, options = {}) options = options.stringify_keys ... end [Note #1: My code uses `merge` to respect the existing behavior of duplicating the `options` hash before updating its keys, see #17096 (comment)] [Note #2: My code uses symbols instead of strings (e.g.: `:hidden`) to look forward to future version of Ruby/Raiks (GC symbols); the result of the method, however, is the same, because the symbols are stringified inside `text_field_tag`] [Note #3: I had previously created a similar PR #17096 but decided to split it into multiple PRs given the feedback received in the comments]
Remove guides/output directory from git
Fix n+1 query problem when eager loading nil associations (fixes #18312)
Fix repo infomation in welcome messages
Rails are on the railroad. Django was a person. |
This is an instance method on the request object now so we don't need it anymore
Please re-open. I'm having trouble with irb(main):003:0> require "Django"
LoadError: cannot load such file -- Django
from /usr/local/Cellar/ruby/2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
from /usr/local/Cellar/ruby/2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
from (irb):3
from /usr/local/bin/irb:11:in `<main>' |
And make sure that it doesn't even try to call the method in the target.
I have an issue with this.
The text was updated successfully, but these errors were encountered: