Revamp CI: matrix, multi-Cirq #755
Conversation
mpharrigan
force-pushed
the
2021-11-matrix
branch
from
be92f8e
to
e7b9e2e
Compare
|
So in order to merge a PR now, one must write working changes for OpenFermion that span Cirq ~= 0.12, Cirq 0.13.0 and the latest Cirq-Dev ? |
|
If there's a true need for a recent Cirq version, that would be made explicit by bumping the min version in In practice, openfermion has rarely been in this situation as of late. |
|
What about the case of a breaking change between cirq 0.13 and 0.14-dev ? |
|
we should fix openfermion to not break with 0.14-dev? |
|
@ncrubin what do you think |
|
I agree with Matt. if issues come up we can resolve and bump min version. |
|
Since this changes the names of expected checks, we need to configure the repository settings or it will keep waiting for the old ci job names |
|
Actually I guess TFQ has next-cirq running in a nightly build. This is better, as it won't hold up unrelated PRs (but perhaps is more easily ignored?) |
mpharrigan
dismissed stale reviews from ncrubin and MichaelBroughton
via
cfc6508
|
@ncrubin @MichaelBroughton my push dismissed your LGTMs. Please re-approve. I'll force-merge and then edit the list of required checks to match the new name. When we bump Cirq or Python it will change the name of the matrix build and we (I) will have to change the list of required checks. If this is too onerous, there's a clunky workaround (where you make one final job that depends on the matrix build job succeeding), but I don't think that will be necessary. |
|
I force merged this and I've updated the required test for future PRs. Please ping me if there are issues with any future PRs |
* CI fun * Try nightly Co-authored-by: Nicholas Rubin <[email protected]>
install_requires. Lower bound only. More often than not, we are artificially restricting dependers from using the latest Cirq than preventing real problems. Testing against pre-release should prevent surprises.