Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing in the presence of sorting or filtering #58

Merged
merged 2 commits into from
Feb 22, 2016

Conversation

blink1073
Copy link
Contributor

No description provided.

@TimShawver
Copy link
Contributor

hey @blink1073 I'm available to look at this when it's ready. Just ping me and I'll take a look. I'm updating docs and will include a caveat about add/remove being experimental for now.

@blink1073
Copy link
Contributor Author

Hi @TimShawver, this should be good to go.

@TimShawver
Copy link
Contributor

@blink1073 this isn't working for me 😢 I'm getting the same "unique id" error mentioned here: #59

The case I was testing was the Example 2 in the new sample notebook here: https://github.com/quantopian/qgrid/blob/master/qgrid_demo.ipynb

Could you try that out and let me know if Add/Remove work for you in that notebook?

@TimShawver
Copy link
Contributor

@blink1073 looks much better. Add/Remove seem to work, but if you remove more than one row, the following error message gets printed out for each removal.

screen shot 2016-02-22 at 3 21 03 pm

I'm going to merge anyways since this is a big improvement compared to the behavior on master right now.

TimShawver added a commit that referenced this pull request Feb 22, 2016
Fix indexing in the presence of sorting or filtering
@TimShawver TimShawver merged commit 4b77bdb into quantopian:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants