[4981][IMP] product_carousel_image_attachment #151
+90
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanda999
reviewed
Nov 25, 2024
Comment on lines
15
to
21
| max_resolution = ( | ||
| "1025x1025" # Use 1025 instead of 1024 to enable the zoom feature | ||
| ) | ||
| quality = int(ICP("base.image_autoresize_quality", 80)) | ||
| img = ImageProcess(datas, verify_resolution=False) | ||
| w, h = img.image.size | ||
| nw, nh = map(int, max_resolution.split("x")) |
There was a problem hiding this comment.
Suggested change
| max_resolution = ( | |
| "1025x1025" # Use 1025 instead of 1024 to enable the zoom feature | |
| ) | |
| quality = int(ICP("base.image_autoresize_quality", 80)) | |
| img = ImageProcess(datas, verify_resolution=False) | |
| w, h = img.image.size | |
| nw, nh = map(int, max_resolution.split("x")) | |
| max_resolution = (1025,1025) # Use 1025 instead of 1024 to enable the zoom feature | |
| quality = int(ICP("base.image_autoresize_quality", 80)) | |
| img = ImageProcess(datas, verify_resolution=False) | |
| w, h = img.image.size | |
| nw, nh = max_resolution |
I thought splitting the text is not necessary.
|
@AungKoKoLin1997 |
AungKoKoLin1997
force-pushed
the
15.0-upd-product_carousel_image_attachment
branch
from
c21c928
to
700d7fa
Compare
AungKoKoLin1997
force-pushed
the
15.0-upd-product_carousel_image_attachment
branch
from
700d7fa
to
46e4045
Compare
|
@yostashiro Please review this PR with the latest changes. |
yostashiro
reviewed
Nov 25, 2024
|
|
||
| @api.model | ||
| def _cron_resize_product_image(self, limit): | ||
| images = self.sudo().search([], limit=limit) |
There was a problem hiding this comment.
@AungKoKoLin1997 Would it be possible to filter records by size? There can be so many records unnecessarily processed otherwise. We could live with this if it's hard to do so.
Comment on lines
15
to
18
| if len(images) == limit: | ||
| self.env.ref( | ||
| "product_carousel_image_attachment.resize_product_image" | ||
| )._trigger() |
There was a problem hiding this comment.
With this implementation, is it still possible to cancel the process in the middle if we want to? If not, we should just let this method be triggered based on the intervals defined in the scheduled action, as that is more controllable.
yostashiro
approved these changes
Nov 25, 2024
| <field name="code">model._cron_resize_product_image(1000)</field> | ||
| <field name="user_id" ref="base.user_root" /> | ||
| <field name="interval_number">1</field> | ||
| <field name="interval_type">days</field> |
There was a problem hiding this comment.
Suggested change
| <field name="interval_type">days</field> | |
| <field name="interval_type">hours</field> |
kanda999
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4981