Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscript alef correction #24707

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Subscript alef correction #24707

merged 1 commit into from
Dec 12, 2024

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Dec 12, 2024 •
edited
Loading

Description

Output for U+0656 is AltGr + V

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 12, 2024
zvecr
zvecr requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this header directly is incorrect.

data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson needs updating and util/regen.sh run.

@filterpaper
Subscript alef correction
830c7ef 
Output for U+0656 is AltGr + V
@github-actions github-actions bot added the dd Data Driven Changes label Dec 12, 2024
@filterpaper
Copy link
Contributor Author

Changing this header directly is incorrect.

data/constants/keycodes/extras/keycodes_farsi_0.0.1.hjson needs updating and util/regen.sh run.

It is updated as instructed.

@waffle87 waffle87 merged commit e1351b4 into qmk:develop Dec 12, 2024
5 checks passed
@filterpaper filterpaper deleted the farsi-correction branch December 12, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core dd Data Driven Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @zvecr @waffle87