Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change new-keymap keymap name prompt #24701

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Change new-keymap keymap name prompt #24701

merged 1 commit into from
Dec 11, 2024

Conversation

waffle87
Copy link
Member

Description

As title. "Your GitHub Username?" is a bit vague with regard to choosing a keymap name and probably has higher likelihood of invalid character like -. Name isn't used for copyright/author/etc.

Types of Changes

  • Core

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Dec 10, 2024
@drashna drashna merged commit 0228806 into qmk:develop Dec 11, 2024
5 checks passed
@waffle87 waffle87 mentioned this pull request Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waffle87 @drashna @fauxpark @dunk2k