Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viper/Eagle Replacement PCB: Fix bug where the last underglow led don't update sometimes #24496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Viper/Eagle Replacement PCB: Fix bug where the last underglow led don't update sometimes #24496

wants to merge 1 commit into from

Conversation

4pplet
Copy link
Contributor

@4pplet 4pplet commented Oct 16, 2024

Description

There is a bug where sometimes when unplugging and reconnecting the PCB, the last LED in the underglow chain does not update. This is a workaround where I add a "dummy LED" after the last LED to combat the problem.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@4pplet
potential fix
39acd11 
potential fix
@fauxpark
Copy link
Member

Is this a hardware issue or something wrong with RGBLight? I would rather fix it properly if it's the latter.

@4pplet
Copy link
Contributor Author

4pplet commented Oct 17, 2024

Is this a hardware issue or something wrong with RGBLight? I would rather fix it properly if it's the latter.

I currently suspect this is a hardware issue, I'm not doing anything special in my use of RGBLight. The last LED don't update and get set to yellow when RGBLight is set to a static color and the cable to the PCB is unplugged then inserted again.

@drashna
Copy link
Member

drashna commented Oct 28, 2024

Is this a hardware issue or something wrong with RGBLight? I would rather fix it properly if it's the latter.

I currently suspect this is a hardware issue, I'm not doing anything special in my use of RGBLight. The last LED don't update and get set to yellow when RGBLight is set to a static color and the cable to the PCB is unplugged then inserted again.

Is it possible that this is a timing issue for the ws2812 data? There are a number of timing settings that can be changed.

@fauxpark
Copy link
Member

You could also try a different driver, if the pin allows. I don't think there should be anything wrong with the default bitbang driver on F072 though.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4pplet @fauxpark @drashna