-
-
Notifications
You must be signed in to change notification settings - Fork 40.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skyloong Gk104 q1 ansi keyboard #23256
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like you have a lot of duplicate code here. A lot of it could and really should be de-duplicated.
4c5b143
to
003e170
Compare
OK, Thank you. Co-authored-by: Joel Challis <[email protected]>
OK, Thank you. Co-authored-by: Joel Challis <[email protected]>
OK, I see. Co-authored-by: Joel Challis <[email protected]>
OK, I see. Co-authored-by: Joel Challis <[email protected]>
OK, Thank you. Co-authored-by: Joel Challis <[email protected]>
OK, Thank you. Co-authored-by: Joel Challis <[email protected]>
OK, I see. Thank you very much. Co-authored-by: Joel Challis <[email protected]>
Yes, SPI1 didn`t be used. Thank you. Co-authored-by: Joel Challis <[email protected]>
OK, Thank you. Co-authored-by: Drashna Jaelre <[email protected]>
OK, Thank you. Co-authored-by: Drashna Jaelre <[email protected]>
As of August 26, 2024, As you've submitted a PR containing |
Okey, I see. It`s modified. Would you please check it again @tzarc |
Thank you for your contribution! |
Hello i would love to test this how could i go to flash mode in my keyboard ?( in on linux) |
You can hold the ESC which is on the top-left, then plug the USB into PC. Wait a little, the keyboard is in flashing mode.
…--------------原始邮件--------------
发件人:"yodatak ***@***.***>;
发送时间:2024年12月14日(星期六) 晚上11:41
收件人:"qmk/qmk_firmware" ***@***.***>;
抄送:"JIKEDINGZHI ***@***.***>;"Author ***@***.***>;
主题:Re: [qmk/qmk_firmware] Add Skyloong Gk104 q1 ansi keyboard (PR #23256)
-----------------------------------
Hello i would love to test this how could i go to flash mode in my keyboard ?( in on linux)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Thanks i try but it don't enter in DFU mode is there annother thing i miss ( thanks for make this keyboard upstream bytheway ! )
|
Another way maybe you can to try , pull off the '|' keycap, then you can find a hole on the left of the switch. There is a reset switch in the hole. You can push it using a pointer. When it is clicked once, the keyboard will turn in DFU mode nomarlly. |
Thanks i find it its on top of right shift key and under backspace , i will try this PR maybe its gonna make its upstream quicker ^^ , last question @NaturalZh is a dump with existing firmwire to go back to official firmwire if i mess up ? |
Sure, you just need to reflash the official firmware to restore it. Anyway, Thank you for tring to merge this PR sooner. |
What else can I do and who can merge it? |
Create a skyloong gk104 q1 ansi keyboard
Description
The Skyloong GK104 Q1 keyboard is an RGB matrix keyboard with LED digital display.
Types of Changes
Issues Fixed or Closed by This PR
Checklist