Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skyloong Gk104 q1 ansi keyboard #23256

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from

Conversation

NaturalZh
Copy link

Create a skyloong gk104 q1 ansi keyboard

Description

The Skyloong GK104 Q1 keyboard is an RGB matrix keyboard with LED digital display.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Mar 11, 2024
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you have a lot of duplicate code here. A lot of it could and really should be de-duplicated.

NaturalZh and others added 21 commits April 3, 2024 11:29
OK, Thank you.

Co-authored-by: Joel Challis <[email protected]>
OK, Thank you.

Co-authored-by: Joel Challis <[email protected]>
OK, I see.

Co-authored-by: Joel Challis <[email protected]>
OK, I see.

Co-authored-by: Joel Challis <[email protected]>
OK, Thank you.

Co-authored-by: Joel Challis <[email protected]>
OK, Thank you.

Co-authored-by: Joel Challis <[email protected]>
OK, I see. Thank you very much.

Co-authored-by: Joel Challis <[email protected]>
Yes, SPI1 didn`t be used. Thank you.

Co-authored-by: Joel Challis <[email protected]>
OK, Thank you.

Co-authored-by: Drashna Jaelre <[email protected]>
OK, Thank you.

Co-authored-by: Drashna Jaelre <[email protected]>
@NaturalZh NaturalZh requested a review from zvecr June 17, 2024 07:42
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

@NaturalZh
Copy link
Author

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Okey, I see. It`s modified. Would you please check it again @tzarc

Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2024
@NaturalZh
Copy link
Author

Would you please review this PR and merge it ?
Many thanks for your help @tzarc @zvecr @drashna

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2024
@NaturalZh NaturalZh requested a review from drashna October 26, 2024 08:31
@NaturalZh
Copy link
Author

Would you please check and merge this PR ? @drashna @zvecr

@yodatak
Copy link

yodatak commented Dec 14, 2024

Hello i would love to test this how could i go to flash mode in my keyboard ?( in on linux)

@NaturalZh
Copy link
Author

NaturalZh commented Dec 15, 2024 via email

@yodatak
Copy link

yodatak commented Jan 5, 2025

Thanks i try but it don't enter in DFU mode is there annother thing i miss ( thanks for make this keyboard upstream bytheway ! )

You can hold the ESC which is on the top-left, then plug the USB into PC. Wait a little, the keyboard is in flashing mode.

--------------原始邮件-------------- 发件人:"yodatak @.>; 发送时间:2024年12月14日(星期六) 晚上11:41 收件人:"qmk/qmk_firmware" @.>; 抄送:"JIKEDINGZHI @.>;"Author @.>; 主题:Re: [qmk/qmk_firmware] Add Skyloong Gk104 q1 ansi keyboard (PR #23256) ----------------------------------- Hello i would love to test this how could i go to flash mode in my keyboard ?( in on linux) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

@NaturalZh
Copy link
Author

Thanks i try but it don't enter in DFU mode is there annother thing i miss ( thanks for make this keyboard upstream bytheway ! )

You can hold the ESC which is on the top-left, then plug the USB into PC. Wait a little, the keyboard is in flashing mode.

--------------原始邮件-------------- 发件人:"yodatak @.>; 发送时间:2024年12月14日(星期六) 晚上11:41 收件人:"qmk/qmk_firmware" _@**._>; 抄送:"JIKEDINGZHI _@.>;"Author @._>; 主题:Re: [qmk/qmk_firmware] Add Skyloong Gk104 q1 ansi keyboard (PR #23256) ----------------------------------- Hello i would love to test this how could i go to flash mode in my keyboard ?( in on linux) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: _@_.*>

Another way maybe you can to try , pull off the '|' keycap, then you can find a hole on the left of the switch. There is a reset switch in the hole. You can push it using a pointer. When it is clicked once, the keyboard will turn in DFU mode nomarlly.

@yodatak
Copy link

yodatak commented Jan 6, 2025

Thanks i find it its on top of right shift key and under backspace , i will try this PR maybe its gonna make its upstream quicker ^^ , last question @NaturalZh is a dump with existing firmwire to go back to official firmwire if i mess up ?

@NaturalZh
Copy link
Author

Thanks i find it its on top of right shift key and under backspace , i will try this PR maybe its gonna make its upstream quicker ^^ , last question @NaturalZh is a dump with existing firmwire to go back to official firmwire if i mess up ?

Sure, you just need to reflash the official firmware to restore it. Anyway, Thank you for tring to merge this PR sooner.

@NaturalZh
Copy link
Author

What else can I do and who can merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants