Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD keyboard Projectd/65/Projectd_65_ iso #21941

Open
wants to merge 116 commits into
base: master
Choose a base branch
from
Open

ADD keyboard Projectd/65/Projectd_65_ iso #21941

wants to merge 116 commits into from
+609 −0

Conversation

gskygithub
Copy link
Contributor

Description

ADD project_65_iso keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

gskygithub added 30 commits June 7, 2022 09:19
@gskygithub
Add files via upload
d9588c0
@gskygithub
[keyboard]
8c7aff1
@gskygithub
[Keyboard]
1dd4c87
@gskygithub
Delete flash_spi.c
74e52d3
@gskygithub
Delete flash_spi.h
19b7d38
@gskygithub
Delete wb32_spi_master.c
7f77d7a
@gskygithub
Delete wb32_spi_master.h
2c0fe84
@gskygithub
[Keyboard]
ecbff72
@gskygithub
Resolved requested changes
9c423d1
@gskygithub
Resolved requested changes
318c463
@gskygithub
Changed rules.mk file accordingly.
dd42220
@gskygithub
Resolved changes accordingly.
52a3301
@gskygithub
Update config.h file and rules.mk file
1c3f1e6
@gskygithub
Removed eeprom_flash.c file
8db03c1
@gskygithub
Update default/keymap.c file
6b050ac
@gskygithub
Delete keyboards/darkproject/kd83a_bfg_edition directory
03ff34c
@gskygithub
Add keyboard
da0a8e5
@gskygithub
Merge branch 'qmk:master' into master
733cf2c
@gskygithub
Add keyboard
273d1da
@gskygithub
Delete darkproject/kd83a_bfg_edition directory
4f3f6c9
@gskygithub
Resolved Changes
4773980
@gskygithub
Merge branch 'qmk:master' into master
ded388f
@gskygithub
Resolved requested changes
e79a657
@gskygithub
Merge branch 'qmk:master' into master
5fedd8a
@gskygithub
keyboard
c89ae6b
@gskygithub
Add keyboard
45d803f
@gskygithub
Delete keyboard
11e36a3
@gskygithub
Merge branch 'qmk:master' into master
1dce29e
@gskygithub
Merge branch 'qmk:master' into master
71157f0
@gskygithub
Add keyboard
5d9043d
@gskygithub gskygithub requested a review from waffle87 April 3, 2024 08:13
@drashna drashna requested a review from a team May 2, 2024 22:37
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 17, 2024
fauxpark
fauxpark requested changes Jun 17, 2024
View reviewed changes
keyboards/projectd/65/projectd_65_iso/rules.mk Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be deleted.

keyboards/projectd/65/projectd_65_iso/info.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still outstanding, and this file can also be renamed to keyboard.json.

fauxpark
fauxpark requested changes Jun 17, 2024
View reviewed changes
keyboards/projectd/65/projectd_65_iso/keyboard.json Outdated
Comment on lines 112 to 152
{ "flags": 4, "matrix": [8, 4], "x": 137.5, "y": 10 },
{ "flags": 4, "matrix": [7, 3], "x": 150, "y": 10 },
{ "flags": 1, "matrix": [2, 1], "x": 0, "y": 20 },
{ "flags": 4, "matrix": [1, 2], "x": 17.5, "y": 20 },
{ "flags": 4, "matrix": [2, 2], "x": 27.5, "y": 20 },
{ "flags": 4, "matrix": [3, 2], "x": 37.5, "y": 20 },
{ "flags": 4, "matrix": [4, 2], "x": 47.5, "y": 20 },
{ "flags": 4, "matrix": [4, 3], "x": 57.5, "y": 20 },
{ "flags": 4, "matrix": [5, 3], "x": 67.5, "y": 20 },
{ "flags": 4, "matrix": [5, 2], "x": 77.5, "y": 20 },
{ "flags": 4, "matrix": [6, 2], "x": 87.5, "y": 20 },
{ "flags": 4, "matrix": [7, 2], "x": 97.5, "y": 20 },
{ "flags": 4, "matrix": [8, 2], "x": 107.5, "y": 20 },
{ "flags": 4, "matrix": [8, 3], "x": 117.5, "y": 20 },
{ "flags": 4, "matrix": [7, 5], "x": 127.5, "y": 20 },
{ "flags": 4, "matrix": [2, 6], "x": 150, "y": 20 },
{ "flags": 4, "matrix": [0, 0], "x": 0, "y": 30 },
{ "flags": 4, "matrix": [0, 4], "x": 12.5, "y": 30 },
{ "flags": 4, "matrix": [1, 4], "x": 22.5, "y": 30 },
{ "flags": 4, "matrix": [2, 4], "x": 32.5, "y": 30 },
{ "flags": 4, "matrix": [3, 4], "x": 42.5, "y": 30 },
{ "flags": 4, "matrix": [4, 4], "x": 52.5, "y": 30 },
{ "flags": 4, "matrix": [4, 5], "x": 62.5, "y": 30 },
{ "flags": 4, "matrix": [5, 5], "x": 72.5, "y": 30 },
{ "flags": 4, "matrix": [5, 4], "x": 82.5, "y": 30 },
{ "flags": 4, "matrix": [6, 4], "x": 92.5, "y": 30 },
{ "flags": 4, "matrix": [7, 4], "x": 102.5, "y": 30 },
{ "flags": 4, "matrix": [8, 5], "x": 112.5, "y": 30 },
{ "flags": 4, "matrix": [0, 7], "x": 122.5, "y": 30 },
{ "flags": 4, "matrix": [1, 6], "x": 140, "y": 30 },
{ "flags": 4, "matrix": [6, 3], "x": 150, "y": 30 },
{ "flags": 4, "matrix": [0, 6], "x": 0, "y": 40 },
{ "flags": 4, "matrix": [0, 5], "x": 12.5, "y": 40 },
{ "flags": 4, "matrix": [0, 2], "x": 25, "y": 40 },
{ "flags": 4, "x": 61.5, "y": 40 },
{ "flags": 4, "x": 62.5, "y": 40 },
{ "flags": 4, "matrix": [0, 1], "x": 65, "y": 40 },
{ "flags": 4, "x": 67.5, "y": 40 },
{ "flags": 4, "x": 68.5, "y": 40 },
{ "flags": 4, "matrix": [3, 6], "x": 100, "y": 40 },
{ "flags": 4, "matrix": [3, 3], "x": 112.5, "y": 40 },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ "flags": 4, "matrix": [8, 4], "x": 137.5, "y": 10 },
{ "flags": 4, "matrix": [7, 3], "x": 150, "y": 10 },
{ "flags": 1, "matrix": [2, 1], "x": 0, "y": 20 },
{ "flags": 4, "matrix": [1, 2], "x": 17.5, "y": 20 },
{ "flags": 4, "matrix": [2, 2], "x": 27.5, "y": 20 },
{ "flags": 4, "matrix": [3, 2], "x": 37.5, "y": 20 },
{ "flags": 4, "matrix": [4, 2], "x": 47.5, "y": 20 },
{ "flags": 4, "matrix": [4, 3], "x": 57.5, "y": 20 },
{ "flags": 4, "matrix": [5, 3], "x": 67.5, "y": 20 },
{ "flags": 4, "matrix": [5, 2], "x": 77.5, "y": 20 },
{ "flags": 4, "matrix": [6, 2], "x": 87.5, "y": 20 },
{ "flags": 4, "matrix": [7, 2], "x": 97.5, "y": 20 },
{ "flags": 4, "matrix": [8, 2], "x": 107.5, "y": 20 },
{ "flags": 4, "matrix": [8, 3], "x": 117.5, "y": 20 },
{ "flags": 4, "matrix": [7, 5], "x": 127.5, "y": 20 },
{ "flags": 4, "matrix": [2, 6], "x": 150, "y": 20 },
{ "flags": 4, "matrix": [0, 0], "x": 0, "y": 30 },
{ "flags": 4, "matrix": [0, 4], "x": 12.5, "y": 30 },
{ "flags": 4, "matrix": [1, 4], "x": 22.5, "y": 30 },
{ "flags": 4, "matrix": [2, 4], "x": 32.5, "y": 30 },
{ "flags": 4, "matrix": [3, 4], "x": 42.5, "y": 30 },
{ "flags": 4, "matrix": [4, 4], "x": 52.5, "y": 30 },
{ "flags": 4, "matrix": [4, 5], "x": 62.5, "y": 30 },
{ "flags": 4, "matrix": [5, 5], "x": 72.5, "y": 30 },
{ "flags": 4, "matrix": [5, 4], "x": 82.5, "y": 30 },
{ "flags": 4, "matrix": [6, 4], "x": 92.5, "y": 30 },
{ "flags": 4, "matrix": [7, 4], "x": 102.5, "y": 30 },
{ "flags": 4, "matrix": [8, 5], "x": 112.5, "y": 30 },
{ "flags": 4, "matrix": [0, 7], "x": 122.5, "y": 30 },
{ "flags": 4, "matrix": [1, 6], "x": 140, "y": 30 },
{ "flags": 4, "matrix": [6, 3], "x": 150, "y": 30 },
{ "flags": 4, "matrix": [0, 6], "x": 0, "y": 40 },
{ "flags": 4, "matrix": [0, 5], "x": 12.5, "y": 40 },
{ "flags": 4, "matrix": [0, 2], "x": 25, "y": 40 },
{ "flags": 4, "x": 61.5, "y": 40 },
{ "flags": 4, "x": 62.5, "y": 40 },
{ "flags": 4, "matrix": [0, 1], "x": 65, "y": 40 },
{ "flags": 4, "x": 67.5, "y": 40 },
{ "flags": 4, "x": 68.5, "y": 40 },
{ "flags": 4, "matrix": [3, 6], "x": 100, "y": 40 },
{ "flags": 4, "matrix": [3, 3], "x": 112.5, "y": 40 },
{ "flags": 4, "matrix": [8, 4], "x": 137, "y": 10 },
{ "flags": 4, "matrix": [7, 3], "x": 150, "y": 10 },
{ "flags": 1, "matrix": [2, 1], "x": 0, "y": 20 },
{ "flags": 4, "matrix": [1, 2], "x": 17, "y": 20 },
{ "flags": 4, "matrix": [2, 2], "x": 27, "y": 20 },
{ "flags": 4, "matrix": [3, 2], "x": 37, "y": 20 },
{ "flags": 4, "matrix": [4, 2], "x": 47, "y": 20 },
{ "flags": 4, "matrix": [4, 3], "x": 57, "y": 20 },
{ "flags": 4, "matrix": [5, 3], "x": 67, "y": 20 },
{ "flags": 4, "matrix": [5, 2], "x": 77, "y": 20 },
{ "flags": 4, "matrix": [6, 2], "x": 87, "y": 20 },
{ "flags": 4, "matrix": [7, 2], "x": 97, "y": 20 },
{ "flags": 4, "matrix": [8, 2], "x": 107, "y": 20 },
{ "flags": 4, "matrix": [8, 3], "x": 117, "y": 20 },
{ "flags": 4, "matrix": [7, 5], "x": 127, "y": 20 },
{ "flags": 4, "matrix": [2, 6], "x": 150, "y": 20 },
{ "flags": 4, "matrix": [0, 0], "x": 0, "y": 30 },
{ "flags": 4, "matrix": [0, 4], "x": 12, "y": 30 },
{ "flags": 4, "matrix": [1, 4], "x": 22, "y": 30 },
{ "flags": 4, "matrix": [2, 4], "x": 32, "y": 30 },
{ "flags": 4, "matrix": [3, 4], "x": 42, "y": 30 },
{ "flags": 4, "matrix": [4, 4], "x": 52, "y": 30 },
{ "flags": 4, "matrix": [4, 5], "x": 62, "y": 30 },
{ "flags": 4, "matrix": [5, 5], "x": 72, "y": 30 },
{ "flags": 4, "matrix": [5, 4], "x": 82, "y": 30 },
{ "flags": 4, "matrix": [6, 4], "x": 92, "y": 30 },
{ "flags": 4, "matrix": [7, 4], "x": 102, "y": 30 },
{ "flags": 4, "matrix": [8, 5], "x": 112, "y": 30 },
{ "flags": 4, "matrix": [0, 7], "x": 122, "y": 30 },
{ "flags": 4, "matrix": [1, 6], "x": 140, "y": 30 },
{ "flags": 4, "matrix": [6, 3], "x": 150, "y": 30 },
{ "flags": 4, "matrix": [0, 6], "x": 0, "y": 40 },
{ "flags": 4, "matrix": [0, 5], "x": 12, "y": 40 },
{ "flags": 4, "matrix": [0, 2], "x": 25, "y": 40 },
{ "flags": 4, "x": 61, "y": 40 },
{ "flags": 4, "x": 62, "y": 40 },
{ "flags": 4, "matrix": [0, 1], "x": 65, "y": 40 },
{ "flags": 4, "x": 67, "y": 40 },
{ "flags": 4, "x": 68, "y": 40 },
{ "flags": 4, "matrix": [3, 6], "x": 100, "y": 40 },
{ "flags": 4, "matrix": [3, 3], "x": 112, "y": 40 },

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 18, 2024
@gskygithub gskygithub requested a review from fauxpark June 19, 2024 01:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Sep 3, 2024
@ZakDggn
Copy link

ZakDggn commented Dec 10, 2024

@waffle87 Is this ready to be merged? It's been approved by the other reviewers and it looks like your requested changes have been resolved. Thanks.

@fauxpark fauxpark reopened this Dec 10, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 11, 2024
@gskygithub gskygithub requested a review from fauxpark December 11, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@drashna drashna drashna approved these changes

@waffle87 waffle87 Awaiting requested review from waffle87

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gskygithub @dunk2k @ZakDggn @drashna @fauxpark @waffle87