Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: add Bluetooth related constants #495

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

antoniovazquezblanco
Copy link
Contributor

Getting in touch with the library. I work with Bluetooth devices, those constants are useful to me.
Those constants may be also useful to others :D

@jonasmalacofilho
Copy link
Member

jonasmalacofilho commented Oct 20, 2023

LGTM, thanks.

Of course, it's a bit odd to add new stuff to a module called legacy. But I also feel that the new constants belong there more than in util, so I'm fine with it...

Can you leave a link here (in the PR comments) to the normative reference for the new constants?

Oh, and just out of curiosity, are you using the legacy API?

@antoniovazquezblanco
Copy link
Contributor Author

Oh, and just out of curiosity, are you using the legacy API?

I am using the new API :)

Of course, it's a bit odd to add new stuff to a module called legacy. But I also feel that the new constants belong there more than in util, so I'm fine with it...

Yep, that was odd haha. In fact I needed to perform a search to find the location of the constants...

I was wondering if there was a better place to put them but I am not familiar with the project :/

Can you leave a link here (in the PR comments) to the normative reference for the new constants?

https://www.usb.org/defined-class-codes

Thank you!

@jonasmalacofilho
Copy link
Member

Thanks again!

@jonasmalacofilho jonasmalacofilho merged commit ffd9792 into pyusb:master Oct 20, 2023
12 checks passed
@antoniovazquezblanco antoniovazquezblanco deleted the constants branch October 20, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants