[dynamo][hops] Use flatten_automatic for local_map #170258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the passing test now. Dynamo lifts the tensor args in order, which is the requirement for local_map. [ghstack-poisoned]
This was referenced Dec 11, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/170258
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 3 Unrelated FailuresAs of commit e1d7fa7 with merge base 7ca3ac5 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
anijain2305
added
ciflow/trunk
See the passing test now. Dynamo lifts the tensor args in order, which is the requirement for local_map. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
Member
|
Nice. Q: What happens when we have interleaved tensors and non-tensors, do the tensor inputs get lifted in order first? e.g. |
Contributor
Author
Yes, only tensors get lifted. obj will be flattened, and if they have tensors, they will be lifted. |
See the passing test now. Dynamo lifts the tensor args in order, which is the requirement for local_map. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
xmfan
approved these changes
Dec 13, 2025
Member
xmfan
left a comment
xmfan
left a comment
There was a problem hiding this comment.
LGTM, I verified this PR works with Autoparallel examples and in torchtitan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See the passing test now. Dynamo lifts the tensor args in order, which
is the requirement for local_map.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo