chore: PP309: Filter warnings specified #9620
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
filterwarnings
branch
from
fa5de79 to
4ebb317
Compare
Apply repo-review suggestion PP309: filterwarnings must be set (probably to at least ["error"]). Python will hide important warnings otherwise, like deprecations.
DimitriPapadopoulos
force-pushed
the
filterwarnings
branch
from
4ebb317 to
0864548
Compare
abn
reviewed
Jan 17, 2025
| @@ -199,6 +199,7 @@ markers = [ | |||
| ] | |||
| log_cli_level = "INFO" | |||
| xfail_strict = true | |||
| filterwarnings = ["error"] | |||
There was a problem hiding this comment.
Suggested change
| filterwarnings = ["error"] | |
| filterwarnings = [ | |
| "error", | |
| "ignore::DeprecationWarning:httpretty.*:", | |
| ] |
You will need something like this atleast due to httpretty.
|
Closing this for now, as this also causes some non-deterministic errors like when files are closed too slowly etc. Thank you @DimitriPapadopoulos for your time and effort. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply repo-review suggestion PP309:
filterwarningsmust be set (probably to at least["error"]). Python will hide important warnings otherwise, like deprecations.Pull Request Check List