Skip to content

Test: vcs.git.backend tests #9507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radoering merged 1 commit into from
Nov 1, 2025
Merged

Test: vcs.git.backend tests #9507

radoering merged 1 commit into from
Nov 1, 2025

Conversation

@indrajithi
Copy link
Contributor

@indrajithi indrajithi commented Jun 20, 2024 •
edited
Loading

Pull Request Check List

Relates-to: #3155

  • Added tests for poetry.vcs.git.backend (increased coverage from 33% to 71%)

@indrajithi indrajithi changed the title Feature/vcs backend tests Test/vcs backend tests Jun 20, 2024
@indrajithi indrajithi changed the title Test/vcs backend tests Test: vcs.git.backend tests Jun 20, 2024
@indrajithi indrajithi marked this pull request as ready for review June 20, 2024 08:18
radoering
radoering requested changes Jun 23, 2024
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions.

PS: Please do not use "Resolves" for a permanent issue (because it will be closed automatically if your PR is merged). I changed it to "Relates-to".

@Secrus Secrus added this to the Poetry 2.0 milestone Oct 6, 2024
@Secrus Secrus removed this from the Poetry 2.0 milestone Nov 5, 2024
abn
abn reviewed Nov 17, 2024
View reviewed changes
@abn
Copy link
Member

abn commented Jan 17, 2025

@indrajithi are you still working on this?

@indrajithi
Copy link
Contributor Author

indrajithi commented Jan 17, 2025 via email

@abn
Copy link
Member

abn commented Jan 18, 2025

Thanks @indrajithi.

No one else is working on it directly.

@indrajithi indrajithi requested a review from radoering June 21, 2025 21:57
@indrajithi
Copy link
Contributor Author

indrajithi commented Jun 21, 2025

@radoering @abn

Can you check this PR and let me know if this looks good?

@indrajithi indrajithi requested a review from abn June 21, 2025 22:41
@indrajithi
Copy link
Contributor Author

indrajithi commented Oct 31, 2025 •
edited
Loading

Hey, just wanted to check on the status of this. Should this be merged or closed?
Thanks!

@indrajithi @radoering
tests: vsc.backend GitRefSpec.test_resolve
ea98a97 
test: add test for Git.get_revision, Git.info and GitRefSpec
@radoering radoering force-pushed the feature/vcs-backend-tests branch from 9e74589 to ea98a97 Compare November 1, 2025 10:44
radoering
radoering approved these changes Nov 1, 2025
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder and sorry for not reacting the first time. It looks like you addressed all open review comments so that I think we can merge it now.

@radoering radoering enabled auto-merge (squash) November 1, 2025 10:51
@radoering radoering merged commit f4a4fd1 into python-poetry:main Nov 1, 2025
63 checks passed
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radoering radoering radoering approved these changes

@abn abn Awaiting requested review from abn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@indrajithi @abn @radoering @Secrus