Skip to content

Redirect downloads/latest/python3.x for given 3.x #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 3 commits into from
Nov 21, 2025
+57 −28
Merged

Redirect downloads/latest/python3.x for given 3.x #2816

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68285eb
Redirect downloads/latest/python3.x for given 3.x
hugovk Nov 21, 2025
0a09306
Use first() instead of qs[0]
hugovk Nov 21, 2025
6be3c24
Combine latest_python3x into latest_python3
hugovk Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Combine latest_python3x into latest_python3
  • Loading branch information
@hugovk
hugovk committed Nov 21, 2025
commit 6be3c249ba68c43264d3879ed92e7858d765f749
14 changes: 5 additions & 9 deletions downloads/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ def pymanager(self):
def latest_python2(self):
return self.python2().filter(is_latest=True)

def latest_python3(self):
return self.python3().filter(is_latest=True)

def latest_python3x(self, minor_version: int):
def latest_python3(self, minor_version: int | None = None):
if minor_version is None:
return self.python3().filter(is_latest=True)
pattern = rf"^Python 3\.{minor_version}\."
return self.python3().filter(name__regex=pattern).order_by("-release_date")

Expand All @@ -50,11 +49,8 @@ class ReleaseManager(Manager.from_queryset(ReleaseQuerySet)):
def latest_python2(self):
return self.get_queryset().latest_python2().first()

def latest_python3(self):
return self.get_queryset().latest_python3().first()

def latest_python3x(self, minor_version: int):
return self.get_queryset().latest_python3x(minor_version).first()
def latest_python3(self, minor_version: int | None = None):
return self.get_queryset().latest_python3(minor_version).first()

def latest_pymanager(self):
return self.get_queryset().latest_pymanager().first()
2 changes: 1 addition & 1 deletion downloads/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def get_redirect_url(self, **kwargs):

try:
minor_version_int = int(minor_version)
latest_release = Release.objects.latest_python3x(minor_version_int)
latest_release = Release.objects.latest_python3(minor_version_int)
except (ValueError, Release.DoesNotExist):
latest_release = None

Expand Down