Skip to content

PEP 817: Wheel Variants: Beyond Platform Tags #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DEKHTIARJonathan wants to merge 10 commits into
base: main
Choose a base branch
from
Open

PEP 817: Wheel Variants: Beyond Platform Tags #4740

DEKHTIARJonathan wants to merge 10 commits into from
+2,678 −0

Conversation

@DEKHTIARJonathan
Copy link

@DEKHTIARJonathan DEKHTIARJonathan commented Dec 10, 2025 •
edited by hugovk
Loading

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

CC: @mgorny @konstin @rgommers @atalman @charliermarsh @msarahan @seemethere @warsaw @dstufft @aterrel

📚 Documentation preview 📚: https://pep-previews--4740.org.readthedocs.build/pep-0817/

@DEKHTIARJonathan DEKHTIARJonathan requested a review from a team as a code owner December 10, 2025 21:54
@python-cla-bot
Copy link

python-cla-bot bot commented Dec 10, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk
Copy link
Member

hugovk commented Dec 10, 2025 •
edited
Loading

Let's renumber this to 9999 for now, we also have #4739 clashing.

@warsaw or @dstufft Please can you confirm co-authorship?

@hugovk hugovk changed the title PEP 817: Wheel Variants: Beyond Platform Tags PEP 9999: Wheel Variants: Beyond Platform Tags Dec 10, 2025
@hugovk hugovk mentioned this pull request Dec 10, 2025
Open
27 tasks
@DEKHTIARJonathan
Copy link
Author

DEKHTIARJonathan commented Dec 10, 2025

Oh thanks @hugovk I totally didn't see that one being published within 20min :D

Let me know which number you want me to pick and I'll do the update ;)

@warsaw
Copy link
Member

warsaw commented Dec 10, 2025

@warsaw or @dstufft Please can you confirm co-authorship?

Confirmed.

@hugovk hugovk changed the title PEP 9999: Wheel Variants: Beyond Platform Tags PEP 817: Wheel Variants: Beyond Platform Tags Dec 10, 2025
@hugovk
Copy link
Member

hugovk commented Dec 10, 2025

Thanks!

@DEKHTIARJonathan You may continue with 817.

hugovk
hugovk reviewed Dec 10, 2025
View reviewed changes
@AA-Turner AA-Turner added the new-pep A new draft PEP submitted for initial review label Dec 11, 2025
AA-Turner
AA-Turner reviewed Dec 11, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very brief review, I haven't yet read beyond the end of Motivation.

A

peps/pep-0817.rst Outdated
Comment on lines 106 to 127
.. figure:: pep-0817/avx512_gromacs_benchmark.png
:alt: A bar graph comparing GROMACS performance (in ns/day) with
various targets. The first two bars are labeled "yum (2018.8)"
and "generic (SSE2)", reach about 1.0 ns/day and are both
marked as "SSE2". The next bar is labeled "ivybridge" ("AVX")
and reaches almost 1.5 ns/day. Two following bars are labeled
"haswell" and "broadwell" (both "AVX2") and exceed 1.5 ns/day
slightly. The last two bars are labeled "skylake_avx512" and
"cascadelake" (both "AVX512") and reach almost 2.0 ns/day.

Performance of GROMACS 2020.1 built for different generations of
CPUs. Vertical axis shows performance expressed in ns/day, a
GROMACS-specific measure of simulation speed (higher is better).

“Compiling `GROMACS <https://www.gromacs.org/>`_ for architectures
that can exploit the AVX-512 instructions supported by the Intel
Cascade Lake microarchitecture gives an additional 18% performance
improvement relative to using AVX2 instructions, with a speedup of
about 70% compared to a generic GROMACS installation with only SSE2.”

— `archspec: A library for detecting, labeling, and reasoning about
microarchitectures <https://tgamblin.github.io/pubs/archspec-canopie-hpc-2020.pdf>`__
Copy link
Member

@AA-Turner AA-Turner Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to be rendered as a block quote?

Copy link
Contributor

@mgorny mgorny Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's quoted (along with the chart) from that paper.

Copy link
Author

@DEKHTIARJonathan DEKHTIARJonathan Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AA-Turner can I resolve the thread ?

@jezdez
Copy link

jezdez commented Dec 11, 2025

Just a brief bystander comment: I'm so stoked to see this PEP draft published!

@hugovk hugovk mentioned this pull request Dec 11, 2025
Merged
@DEKHTIARJonathan
Copy link
Author

DEKHTIARJonathan commented Dec 11, 2025

Just a brief bystander comment: I'm so stoked to see this PEP draft published!

Thanks Jannis! Took some significant amount of work but we eventually got there

@mgorny
Replace the benchmark chart with SVG
78ff40b 
Signed-off-by: Michał Górny <[email protected]>
@mgorny
Compact the SVG
a31b68b 
Signed-off-by: Michał Górny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@AA-Turner AA-Turner AA-Turner left review comments

@emmatyping emmatyping emmatyping left review comments

+2 more reviewers

@mgorny mgorny mgorny left review comments

@konstin konstin konstin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@DEKHTIARJonathan @hugovk @warsaw @jezdez @mgorny @konstin @AA-Turner @emmatyping