Skip to content

Update mypy error messages in code examples, part 1 #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hoefling wants to merge 5 commits into from
Closed

Update mypy error messages in code examples, part 1 #7706

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e3523b
revisited mypy error messages in additional_features.rst
hoefling Oct 13, 2019
5b23ebd
revisited mypy error messages in casts.rst
hoefling Oct 13, 2019
49f5059
revisited mypy error messages in class_basics.rst
hoefling Oct 13, 2019
bd24079
revisited mypy error messages in common_issues.rst
hoefling Oct 13, 2019
f542adb
changed code example where mypy reports incompatible types
hoefling Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revisited mypy error messages in class_basics.rst 
Signed-off-by: Oleg Höfling <[email protected]>
  • Loading branch information
@hoefling
hoefling committed Oct 13, 2019
commit 49f5059be7f3bbaa330b5c3a697f2047303aafa3
12 changes: 6 additions & 6 deletions docs/source/class_basics.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ initialized within the class. Mypy infers the types of attributes:

a = A(1)
a.x = 2 # OK!
a.y = 3 # Error: 'A' has no attribute 'y'
a.y = 3 # error: "A" has no attribute "y"

This is a bit like each class having an implicitly defined
:py:data:`__slots__ <object.__slots__>` attribute. This is only enforced during type
Expand Down Expand Up @@ -76,7 +76,7 @@ to it explicitly using ``self``:
def __init__(self) -> None:
self.y = 1 # Define 'y'
a = self
a.x = 1 # Error: 'x' not defined
a.x = 1 # error: "A" has no attribute "x"

Annotating __init__ methods
***************************
Expand Down Expand Up @@ -124,7 +124,7 @@ particular attribute should not be set on instances:
A.x += 1 # OK

a = A()
a.x = 1 # Error: Cannot assign to class variable "x" via instance
a.x = 1 # error: Cannot assign to class variable "x" via instance
print(a.x) # OK -- can be read through an instance

.. note::
Expand Down Expand Up @@ -183,11 +183,11 @@ override has a compatible signature:
...

class Derived1(Base):
def f(self, x: str) -> None: # Error: type of 'x' incompatible
def f(self, x: str) -> None: # error: Argument 1 of "f" is incompatible with supertype "Base"; supertype defines the argument type as "int"
...

class Derived2(Base):
def f(self, x: int, y: int) -> None: # Error: too many arguments
def f(self, x: int, y: int) -> None: # error: Signature of "f" incompatible with supertype "Base"
...

class Derived3(Base):
Expand Down Expand Up @@ -258,7 +258,7 @@ function decorator. Example:
def can_walk(self) -> bool:
return True

x = Animal() # Error: 'Animal' is abstract due to 'eat' and 'can_walk'
x = Animal() # error: Cannot instantiate abstract class 'Animal' with abstract attributes 'can_walk' and 'eat'
y = Cat() # OK

.. note::
Expand Down