Skip to content

Handle types.ModuleType #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 9 commits into from
Apr 13, 2017
Merged

Handle types.ModuleType #3107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
585ff8d
Allowed use of types.ModuleType
pkch Apr 2, 2017
fbcb6ff
Allow module name override for stub files
pkch Apr 2, 2017
7c739df
Remove superfluous class module
pkch Apr 2, 2017
b53c904
Hard code module renaming
pkch Apr 3, 2017
def95ce
Address CR
pkch Apr 13, 2017
6e8c81a
Updated typeshed
pkch Apr 13, 2017
c43d345
Merge branch 'master' into types-module
pkch Apr 13, 2017
ef70f3e
Fix fine-grained tests
pkch Apr 13, 2017
b956d46
Fix whitespace
ilevkivskyi Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address CR
  • Loading branch information
@pkch
pkch committed Apr 13, 2017
commit def95ce981a8fd7b9a9fa92c4ac7f70b8e9a96c8
2 changes: 1 addition & 1 deletion test-data/unit/check-modules.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,4 +1415,4 @@ def f() -> types.ModuleType:
reveal_type(f()) # E: Revealed type is 'types.ModuleType'
reveal_type(types) # E: Revealed type is 'types.ModuleType'

[builtins fixtures/module.pyi]
[builtins fixtures/module.pyi]
27 changes: 1 addition & 26 deletions test-data/unit/lib-stub/types.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,4 @@ def coroutine(func: T) -> T:

class bool: ...

class ModuleSpec:
def __init__(self, name: str, loader: Optional['Loader'], *,
origin: str = None, loader_state: Any = None,
is_package: bool = None) -> None: ...
name = ... # type: str
loader = ... # type: Optional[Loader]
origin = ... # type: Optional[str]
submodule_search_locations = ... # type: Optional[List[str]]
loader_state = ... # type: Any
cached = ... # type: Optional[str]
parent = ... # type: Optional[str]
has_location = ... # type: bool

class Loader:
def load_module(self, fullname: str) -> ModuleType: ...
def module_repr(self, module: ModuleType) -> str: ...
def create_module(self, spec: ModuleSpec) -> Optional[ModuleType]: ...
def exec_module(self, module: ModuleType) -> None: ...

class ModuleType:
__name__ = ... # type: str
__file__ = ... # type: str
__loader__ = ... # type: Optional[Loader]
__package__ = ... # type: Optional[str]
__spec__ = ... # type: Optional[ModuleSpec]
def __init__(self, name: str, doc: Optional[str] = ...) -> None: ...
class ModuleType: ...
2 changes: 1 addition & 1 deletion typeshed
Open in desktop
Submodule typeshed updated 25 files
+2 −1 stdlib/2/__builtin__.pyi
+0 −10 stdlib/2/copy.pyi
+6 −4 stdlib/2/hashlib.pyi
+1 −6 stdlib/2/md5.pyi
+22 −12 stdlib/2/os/__init__.pyi
+0 −24 stdlib/2/pprint.pyi
+0 −28 stdlib/2/struct.pyi
+0 −42 stdlib/2/zlib.pyi
+5 −1 stdlib/2and3/_random.pyi
+11 −0 stdlib/2and3/copy.pyi
+2 −1 stdlib/2and3/pprint.pyi
+40 −0 stdlib/2and3/struct.pyi
+17 −8 stdlib/2and3/zlib.pyi
+1 −0 stdlib/3.4/asyncio/__init__.pyi
+10 −10 stdlib/3.4/enum.pyi
+0 −12 stdlib/3/_random.pyi
+1 −0 stdlib/3/builtins.pyi
+0 −10 stdlib/3/copy.pyi
+13 −7 stdlib/3/os/__init__.pyi
+68 −0 stdlib/3/socket.pyi
+0 −30 stdlib/3/struct.pyi
+9 −0 third_party/2and3/boto/kms/__init__.pyi
+21 −0 third_party/2and3/boto/kms/exceptions.pyi
+41 −0 third_party/2and3/boto/kms/layer1.pyi
+1 −1 third_party/3/itsdangerous.pyi