Skip to content

gh-81793: always call linkat() from os.link(), if available #24997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takluyver wants to merge 4 commits into from
Closed

gh-81793: always call linkat() from os.link(), if available #24997

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21b0ab7
Add failing test for os.link() with symlink
takluyver Mar 23, 2021
772b3e9
bpo-37612: always call linkat() from os.link(), if available
jo-he Mar 23, 2021
0200894
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 19, 2019
beada2b
Merge branch 'main' into bpo-37612
serhiy-storchaka Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add failing test for os.link() with symlink
  • Loading branch information
@takluyver
takluyver committed Mar 23, 2021
commit 21b0ab709302bbb654ed9e182fdf735ed71c9b25
18 changes: 18 additions & 0 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,6 +1190,24 @@ def test_link_dir_fd(self):
posix.close(f)
os_helper.unlink(os_helper.TESTFN + 'link')

@unittest.skipUnless(os.link in os.supports_follow_symlinks, "test needs follow_symlinks support in os.link()")
def test_link_follow_symlinks(self):
symlink_fn = os_helper.TESTFN + 'symlink'
link_following = os_helper.TESTFN + 'link_following'
link_nofollow = os_helper.TESTFN + 'link_nofollow'
posix.symlink(os_helper.TESTFN, symlink_fn)
self.teardown_files.append(symlink_fn)

# follow_symlinks=False -> duplicate the symlink itself
posix.link(symlink_fn, link_nofollow, follow_symlinks=False)
self.teardown_files.append(link_nofollow)
self.assertEqual(posix.lstat(link_nofollow), posix.lstat(symlink_fn))

# follow_symlinks=True -> duplicate the target file
posix.link(symlink_fn, link_following, follow_symlinks=True)
self.teardown_files.append(link_following)
self.assertEqual(posix.lstat(link_following), posix.lstat(os_helper.TESTFN))

@unittest.skipUnless(os.mkdir in os.supports_dir_fd, "test needs dir_fd support in os.mkdir()")
def test_mkdir_dir_fd(self):
f = posix.open(posix.getcwd(), posix.O_RDONLY)
Expand Down