Skip to content

bpo-37612: always call linkat() from os.link(), if available #14843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jo-he wants to merge 2 commits into from
Closed

bpo-37612: always call linkat() from os.link(), if available #14843

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae2e6e8
bpo-37612: always call linkat() from os.link(), if available
jo-he Jul 18, 2019
264bdad
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-37612: always call linkat() from os.link(), if available 
The issue with link() is that POSIX does not define its behavior
regarding symbolic links:

"If path1 names a symbolic link, it is implementation-defined whether
link() follows the symbolic link, or creates a new link to the symbolic
link itself."

And it is indeed implemented differently on Linux and NetBSD.
  • Loading branch information
@jo-he
jo-he committed Jul 18, 2019
commit ae2e6e84fea71817e8972da08d15d21b33287988
12 changes: 4 additions & 8 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3512,15 +3512,11 @@ os_link_impl(PyObject *module, path_t *src, path_t *dst, int src_dir_fd,
#else
Py_BEGIN_ALLOW_THREADS
#ifdef HAVE_LINKAT
if ((src_dir_fd != DEFAULT_DIR_FD) ||
(dst_dir_fd != DEFAULT_DIR_FD) ||
(!follow_symlinks))
result = linkat(src_dir_fd, src->narrow,
dst_dir_fd, dst->narrow,
follow_symlinks ? AT_SYMLINK_FOLLOW : 0);
else
result = linkat(src_dir_fd, src->narrow, dst_dir_fd, dst->narrow,
follow_symlinks ? AT_SYMLINK_FOLLOW : 0);
#else
result = link(src->narrow, dst->narrow);
#endif /* HAVE_LINKAT */
result = link(src->narrow, dst->narrow);
Py_END_ALLOW_THREADS

if (result)
Expand Down