Skip to content

[3.13] gh-142595: add type check for namedtuple call during decimal initialization (GH-142608) #142622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 1 commit into from
Dec 15, 2025
Merged

[3.13] gh-142595: add type check for namedtuple call during decimal initialization (GH-142608) #142622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-142595: add type check for namedtuple call during decimal initiali… 
…zation (GH-142608)

(cherry picked from commit be5e0dc)

Co-authored-by: Sergey B Kirpichev <[email protected]>
  • Loading branch information
@skirpichev @miss-islington
skirpichev authored and miss-islington committed Dec 12, 2025
commit 0de44c6c5f5f66d53c5ca8bdad86008b3a316c59
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-12-12-02-56-26.gh-issue-142595.wHvTqq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Added type check during initialization of the :mod:`decimal` module to
prevent a crash in case of broken stdlib. Patch by Sergey B Kirpichev.
12 changes: 8 additions & 4 deletions Modules/_decimal/_decimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5922,10 +5922,14 @@ _decimal_exec(PyObject *m)

/* DecimalTuple */
ASSIGN_PTR(collections, PyImport_ImportModule("collections"));
ASSIGN_PTR(state->DecimalTuple, (PyTypeObject *)PyObject_CallMethod(collections,
"namedtuple", "(ss)", "DecimalTuple",
"sign digits exponent"));

obj = PyObject_CallMethod(collections, "namedtuple", "(ss)", "DecimalTuple",
"sign digits exponent");
if (!PyType_Check(obj)) {
PyErr_SetString(PyExc_TypeError,
"type is expected from namedtuple call");
goto error;
}
ASSIGN_PTR(state->DecimalTuple, (PyTypeObject *)obj);
ASSIGN_PTR(obj, PyUnicode_FromString("decimal"));
CHECK_INT(PyDict_SetItemString(state->DecimalTuple->tp_dict, "__module__", obj));
Py_CLEAR(obj);
Expand Down
Loading