Skip to content

gh-64551: Add RFC 5034 AUTH support to poplib #142613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatelei wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-64551: Add RFC 5034 AUTH support to poplib #142613

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c26c9d
feat: pop3 lib support auth
fatelei Dec 12, 2025
b9cb54b
fix: fix test poplib test block forever
fatelei Dec 12, 2025
7c1e4d9
chore: update docstring for auth method
fatelei Dec 12, 2025
759e1e7
chore: update auth method
fatelei Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix test poplib test block forever
  • Loading branch information
@fatelei
fatelei committed Dec 12, 2025
commit b9cb54bd6e99dfdc242e31b973afe9571323cc6c
30 changes: 30 additions & 0 deletions Lib/test/test_poplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,33 @@ def test_auth_rejects_conflicting_args(self):
with self.assertRaises(ValueError):
self.client.auth("PLAIN", authobject=lambda c: b"x", initial_response=b"y")

def test_auth_unsupported_mechanism(self):
with self.assertRaises(poplib.error_proto):
self.client.auth("FOO")

def test_auth_cancel(self):
def authobject(_challenge):
return b"*"
with self.assertRaises(poplib.error_proto):
self.client.auth("PLAIN", authobject=authobject)

def test_auth_mechanism_case_insensitive(self):
secret = b"user\x00adminuser\x00password"
# use lowercase mechanism name to ensure server accepts
resp = self.client.auth("plain", initial_response=secret)
self.assertStartsWith(resp, b"+OK")

def test_auth_initial_response_str(self):
secret = "user\x00adminuser\x00password" # str, not bytes
resp = self.client.auth("PLAIN", initial_response=secret)
self.assertStartsWith(resp, b"+OK")

def test_auth_authobject_returns_str(self):
def authobject(challenge):
return "user\x00adminuser\x00password"
resp = self.client.auth("PLAIN", authobject=authobject)
self.assertStartsWith(resp, b"+OK")

def test_stat(self):
self.assertEqual(self.client.stat(), (10, 100))

Expand Down Expand Up @@ -488,6 +515,9 @@ def __init__(self, conn):
self.push('+OK dummy pop3 server ready. <timestamp>')
self.tls_active = True
self.tls_starting = False
# Initialize AUTH state like DummyPOP3Handler to avoid AttributeError
self._auth_pending = False
self._auth_mech = None


@requires_ssl
Expand Down
Loading