gh-138122: Make Tachyon flamegraph and heatmap output more similar #142590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@StanFromIreland can you post BEFORE/AFTER images for reviewers to see? |
Member
Author
|
I'm afraid it's a bit difficult to capture everything, I would suggest you try it out yourself since there are hover/select effects and the like. How the flamegraph navbar looks: 
How the flamegraph footer looks: 
For heatmaps, instead of "Back to Index" we have: 
|
Member
|
Thanks for the fix @StanFromIreland |
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navbars are now more consistent, with the same text style, button icons and logo. I also added the favicon, footer text, and summary card styling to flamegraph from heatmap.