gh-142585: Add PyMutex_STATIC_INIT macro #142586
Closed
+22
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
AA-Turner,
emmatyping,
ericsnowcurrently,
gpshead and
picnixz
as code owners
vstinner
requested review from
ZeroIntensity,
markshannon and
methane
as code owners
Member
Author
|
cc @colesbury |
colesbury
requested changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
I don't think we should do this:
- The public API is that these are zero initialized. That's important - it simplifies a lot of things, because it's really easy to zero-alloc things.
(PyMutex){0}is the standard zero initialization idiom in C11. It doesn't leak internals and doesn't matter how many fieldsPyMutexhas.PyMutex_STATIC_INITis misnamed as it's not used for static initialization.
|
When you're done making the requested changes, leave the comment: |
Member
Author
Yeah, I hesitated with |
Member
|
I agree with everything Sam mentioned why we shouldn't do this. I'd also say we should avoid introducing new macros in general in the C API. Regardless of whether Rust becomes part of CPython itself, Rust and other 3rd-party FFI bindings need to handle macros specially, and we should avoid giving those projects more work. |
Member
Author
|
Ok, I abandon my PR. Let's not do that :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMutex_STATIC_INITmacro #142585