refactor: refactor test_search_methods_reentrancy_raises_buffererror …

…make it more readable
python · fatelei · Dec 11, 2025 · Dec 11, 2025 · Dec 11, 2025 · Dec 12, 2025
commit b5efa3f66294a8041d0817144c5c39b2b8f7bd4c
diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py
@@ -2062,21 +2062,21 @@ def __index__(self):
 
     def test_search_methods_reentrancy_raises_buffererror(self):
         # gh-142560: Raise BufferError if buffer mutates during search arg conversion.
-        ba = bytearray(b"A")
         class Evil:
+            def __init__(self, ba):
+                self.ba = ba
             def __index__(self):
-                ba.clear()
-                return 65  # ord('A')
-        with self.assertRaises(BufferError):
-            ba.find(Evil())
-        with self.assertRaises(BufferError):
-            ba.count(Evil())
-        with self.assertRaises(BufferError):
-            ba.index(Evil())
-        with self.assertRaises(BufferError):
-            ba.rindex(Evil())
-        with self.assertRaises(BufferError):
-            ba.rfind(Evil())
+                self.ba.clear()
+                return 65
+
+        def make_case():
+            ba = bytearray(b"A")
+            return ba, Evil(ba)
+
+        for name in ("find", "count", "index", "rindex", "rfind"):
+            ba, evil = make_case()
+            with self.assertRaises(BufferError):
+                getattr(ba, name)(evil)
 
 
 class AssortedBytesTest(unittest.TestCase):