gh-142536: Test HTTPStatus items are stringified as values
#142536
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
changed the title
HTTPStatus items are stringified as valuesHTTPStatus items are stringified as values
Contributor
Author
|
@julianz- I don't see this reproducing the inconsistency you've hit in that PR.. Ideas? |
It was discovered by @julianz- [[1]] that this works differently under *NIX and on Windows. So this patch adds a test case to demonstrate the inconsistency. [1]: cherrypy/cheroot#800 (comment)
webknjaz
force-pushed
the
reproducers/httpstatus-str-as-value
branch
from
d26912a to
bd2d16d
Compare
|
@webknjaz Maybe because of a difference in the CI? The failure I saw was in Windows 2022. Update: Oh I see there was a change in Python 3.11 to the way enums are stringified: In https://docs.python.org/3/library/enum.html#enum.IntEnum it says: "Changed in version 3.11: str() is now int.str()" The error was occurring when running with Python 3.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered by @julianz- [1] that this works differently under *NIX and on Windows. So this patch adds a test case to demonstrate the inconsistency.
Specifically, this is how it works on my Gentoo laptop (Python 3.14.0):
However, a CI job in Cheroot revealed that on Windows, it's not the number that's returned but the enum name:
The added test seeks to show this cross-platform difference.