Consistently goto exit in py_posix_spawn
#142532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
added
skip issue
skip news
extension-modules
Member
|
You need to update the branch to fix CI. |
vstinner
added
needs backport to 3.13
|
Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 11, 2025
Consistently use `goto exit;` in `py_posix_spawn()`. (cherry picked from commit 8cfa351) Co-authored-by: Bartosz Sławecki <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 11, 2025
Consistently use `goto exit;` in `py_posix_spawn()`. (cherry picked from commit 8cfa351) Co-authored-by: Bartosz Sławecki <[email protected]>
|
GH-142581 is a backport of this pull request to the 3.13 branch. |
|
GH-142582 is a backport of this pull request to the 3.14 branch. |
Member
|
Merged, thanks for the fix! |
vstinner
pushed a commit
that referenced
this pull request
Dec 11, 2025
Fix os.posix_spawn() error handling (GH-142532) Consistently use `goto exit;` in `py_posix_spawn()`. (cherry picked from commit 8cfa351) Co-authored-by: Bartosz Sławecki <[email protected]>
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
Consistently use `goto exit;` in `py_posix_spawn()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return NULLhas quite the same effect right now --exitdoesn't have anything to clean up at this point of execution.Nevertheless, I think it's better to reduce the possibility of something slipping through in the future.
Especially since all the surrounding preconditions do use
goto exit.CC @ZeroIntensity
extension-modules,skip issue,skip news