gh-138122: Add inverted flamegraph #142288
Merged
+349
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce an inverted flamegraph view that aggregates all leaf nodes. In a standard flamegraph, if a hot function is called from multiple locations, it appears multiple times as separate leaf nodes. In the inverted flamegraph, all occurrences of the same leaf function are merged into a single aggregated node, showing the total hotness of that function in one place. In this inverted view, the children of each aggregated hot function represent its callers, the functions that led to that leaf in the original call tree.
Member
|
@ivonastojanovic unfortunately we had some merge conflicts. Can you fix them when you have some time? |
Resolved conflicts: - flamegraph.js: Combined opcode mapping initialization with inverted flamegraph setup - heatmap.css: Kept heatmap-specific toggle overrides (base toggle styles in base.css) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
|
@ivonastojanovic i fixed the conflicts. We still have this weird bug where if a thread has a single frame it dissapears in inverted version |
Member
|
Ok I think I found the problem, can you double check 500c484? |
pablogsal
approved these changes
Dec 12, 2025
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an inverted flamegraph view that aggregates all leaf nodes. In a standard flamegraph, if a hot function is called from multiple locations, it appears multiple times as separate leaf nodes. In the inverted flamegraph, all occurrences of the same leaf function are merged into a single aggregated node, showing the total hotness of that function in one place.
In this inverted view, the children of each aggregated hot function represent its callers, the functions that led to that leaf in the original call tree.
Standard flamegraph:
Inverted flame graph:
