Skip to content

gh-138122: Implement frame caching in RemoteUnwinder to reduce memory reads #142137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 21 commits into from
Dec 6, 2025
Merged

gh-138122: Implement frame caching in RemoteUnwinder to reduce memory reads #142137

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b2ca1ac
Add last_profiled_frame field to thread state for remote profilers
pablogsal Dec 1, 2025
f36111b
Move write_memory implementation to shared remote_debug.h header
pablogsal Dec 1, 2025
d847cf7
Implement frame caching in RemoteUnwinder to reduce memory reads
pablogsal Dec 1, 2025
19047cf
Enable frame caching by default in the sampling profiler
pablogsal Dec 1, 2025
c56c1e1
Add tests for frame caching in remote debugging
pablogsal Dec 1, 2025
adb0429
Add thread test
pablogsal Dec 1, 2025
315ac74
Add NEWS entry
pablogsal Dec 1, 2025
7d7daa5
Clear stale last_profiled_frame values when initializing RemoteUnwinder
pablogsal Dec 1, 2025
f16f8a5
Fix NEWS entry Sphinx references
pablogsal Dec 1, 2025
b4e3295
Regen stuff
pablogsal Dec 1, 2025
d2aa8a4
Fix frame cache miss handling in RemoteUnwinder to return complete st…
pablogsal Dec 1, 2025
6e88425
make test more reliable
pablogsal Dec 1, 2025
cf15c90
Rework the cache
pablogsal Dec 1, 2025
a9a9efe
make test more reliable
pablogsal Dec 1, 2025
c5307fb
Return only from the frame profiled
pablogsal Dec 2, 2025
5ba13c5
Bump the expected frames
pablogsal Dec 2, 2025
7ecbe13
Add stats
pablogsal Dec 3, 2025
2711907
Regen files
pablogsal Dec 3, 2025
8df2106
Fix frame cache to always re-read current frame for accurate line num…
pablogsal Dec 5, 2025
1944a02
Fixes for small edge cases, docs and cache stats
pablogsal Dec 5, 2025
e528bc1
Fix limits
pablogsal Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return only from the frame profiled
  • Loading branch information
@pablogsal
pablogsal committed Dec 2, 2025
commit c5307fb62a9f63f2e79ae7efa365b03af0988e39
7 changes: 5 additions & 2 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2006,8 +2006,11 @@ _PyEval_FrameClearAndPop(PyThreadState *tstate, _PyInterpreterFrame * frame)
{
// Update last_profiled_frame for remote profiler frame caching.
// By this point, tstate->current_frame is already set to the parent frame.
// The guarded check avoids writes when profiling is not active (predictable branch).
if (tstate->last_profiled_frame != NULL) {
// Only update if we're popping the exact frame that was last profiled.
// This avoids corrupting the cache when transient frames (called and returned
// between profiler samples) update last_profiled_frame to addresses the
// profiler never saw.
if (tstate->last_profiled_frame != NULL && tstate->last_profiled_frame == frame) {
tstate->last_profiled_frame = tstate->current_frame;
}

Expand Down
Loading