Skip to content

gh-138122: New Tachyon UI #142116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 7 commits into from
Dec 1, 2025
Merged

gh-138122: New Tachyon UI #142116

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
205af96
New Tachyon UI
lkollar Nov 30, 2025
3bae723
Fix failing test
lkollar Dec 1, 2025
870b164
Fix error rate
pablogsal Dec 1, 2025
5291b52
Add missing samples
pablogsal Dec 1, 2025
dca0f8a
Merge remote-tracking branch 'upstream/main' into profiling/ui-v2
pablogsal Dec 1, 2025
a276b42
Fix some edge cases
pablogsal Dec 1, 2025
19be9e5
Some simplifications
pablogsal Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Some simplifications
  • Loading branch information
@pablogsal
pablogsal committed Dec 1, 2025
commit 19be9e56a9878dcb5fa41419d651530563c6d1b1
37 changes: 22 additions & 15 deletions Lib/profiling/sampling/flamegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ let currentThreadFilter = 'all';
// ============================================================================

function resolveString(index) {
if (index === null || index === undefined) {
return null;
}
if (typeof index === 'number' && index >= 0 && index < stringTable.length) {
return stringTable[index];
}
Expand Down Expand Up @@ -338,14 +341,20 @@ function ensureLibraryLoaded() {
}
}

const HEAT_THRESHOLDS = [
[0.6, 8],
[0.35, 7],
[0.18, 6],
[0.12, 5],
[0.06, 4],
[0.03, 3],
[0.01, 2],
];

function getHeatLevel(percentage) {
if (percentage >= 0.6) return 8;
if (percentage >= 0.35) return 7;
if (percentage >= 0.18) return 6;
if (percentage >= 0.12) return 5;
if (percentage >= 0.06) return 4;
if (percentage >= 0.03) return 3;
if (percentage >= 0.01) return 2;
for (const [threshold, level] of HEAT_THRESHOLDS) {
if (percentage >= threshold) return level;
}
return 1;
}

Expand Down Expand Up @@ -514,13 +523,11 @@ function clearSearch() {
// Resize Handler
// ============================================================================

function handleResize(chart, data) {
function handleResize() {
let resizeTimeout;
window.addEventListener("resize", function () {
clearTimeout(resizeTimeout);
resizeTimeout = setTimeout(function () {
resizeChart();
}, 100);
resizeTimeout = setTimeout(resizeChart, 100);
});
}

Expand Down Expand Up @@ -735,11 +742,11 @@ function populateStats(data) {
function collectFunctions(node) {
if (!node) return;

let filename = typeof node.filename === 'number' ? resolveString(node.filename) : node.filename;
let funcname = typeof node.funcname === 'number' ? resolveString(node.funcname) : node.funcname;
let filename = resolveString(node.filename);
let funcname = resolveString(node.funcname);

if (!filename || !funcname) {
const nameStr = typeof node.name === 'number' ? resolveString(node.name) : node.name;
const nameStr = resolveString(node.name);
if (nameStr?.includes('(')) {
const match = nameStr.match(/^(.+?)\s*\((.+?):(\d+)\)$/);
if (match) {
Expand Down Expand Up @@ -993,7 +1000,7 @@ function initFlamegraph() {
renderFlamegraph(chart, processedData);
initSearchHandlers();
initSidebarResize();
handleResize(chart, processedData);
handleResize();
}

if (document.readyState === "loading") {
Expand Down
Loading