Skip to content

gh-138122: Don't sample partial frame chains #141912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 10 commits into from
Dec 7, 2025
+138 −108
Merged

gh-138122: Don't sample partial frame chains #141912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7209306
gh-138122: Add incomplete sample detection and fix generator frame un…
pablogsal Nov 24, 2025
111e70c
Implement mark's idea
pablogsal Nov 25, 2025
664d439
Add note to the docs
pablogsal Nov 25, 2025
29a04b7
Fix frame termination
pablogsal Nov 25, 2025
3d9c294
Fix assignment
pablogsal Nov 25, 2025
e14dc8e
ReuseFRAME_OWNED_BY_INTERPRETER
pablogsal Nov 27, 2025
9986d88
Merge upstream/main into gh-138122-fix
pablogsal Dec 6, 2025
13bd7e4
Fix thread cache test
pablogsal Dec 7, 2025
a01bd24
Merge upstream/main into gh-138122-fix
pablogsal Dec 7, 2025
c9ab431
Fix warnings
pablogsal Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix frame termination
  • Loading branch information
@pablogsal
pablogsal committed Nov 25, 2025
commit 29a04b78bdddb865ae32cbdf80a3312bf2a727c0
2 changes: 1 addition & 1 deletion Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2571,7 +2571,7 @@ Py_EndInterpreter(PyThreadState *tstate)
if (tstate != _PyThreadState_GET()) {
Py_FatalError("thread is not current");
}
if (tstate->current_frame != NULL) {
if (tstate->current_frame != tstate->base_frame) {
Py_FatalError("thread still has a frame");
}
interp->finalizing = 1;
Expand Down
2 changes: 1 addition & 1 deletion Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ PyThreadState_Clear(PyThreadState *tstate)

int verbose = _PyInterpreterState_GetConfig(tstate->interp)->verbose;

if (verbose && tstate->current_frame != NULL) {
if (verbose && tstate->current_frame != tstate->base_frame) {
/* bpo-20526: After the main thread calls
_PyInterpreterState_SetFinalizing() in Py_FinalizeEx()
(or in Py_EndInterpreter() for subinterpreters),
Expand Down
Loading